Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fedekunze/1010 lcd stake" #1120

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Aug 10, 2018

Reverts #1068

getting a bugs w this new version:

log in, shows i have 20 stake
this is correct because i have 40 staked to nylira

go to staking – no DDoS : )
BUT
order by my votes, shows i have no stake delegated to nylira
go to nylira's page, still says i have no stake delegated to nylira
try to add 1 of my current 20 steak to nylira
get a 404 from my POST request to:

http://localhost:9070/stake/delegators/cosmosaccaddr18tkxwzhyn4a5ss63vttwpespvm7kxm895m9ppf/delegations

with payload:

{"delegations":[{"delegator_addr":"cosmosaccaddr18tkxwzhyn4a5ss63vttwpespvm7kxm895m9ppf","validator_addr":"cosmosaccaddr1l0qw5znfd6e8pshpjvyghjjzyr4l6ymla080lt","delegation":{"denom":"steak","amount":"1"}}],"begin_unbondings":[],"sequence":"2","name":"okwme","password":"asdfasdfasdf","account_number":"367","chain_id":"gaia-7005","gas":"50000000"}

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #1120 into develop will increase coverage by 1.13%.
The diff coverage is 94.28%.

@@             Coverage Diff             @@
##           develop    #1120      +/-   ##
===========================================
+ Coverage    96.05%   97.18%   +1.13%     
===========================================
  Files           81       79       -2     
  Lines         1595     1525      -70     
  Branches        79       77       -2     
===========================================
- Hits          1532     1482      -50     
+ Misses          56       36      -20     
  Partials         7        7
Impacted Files Coverage Δ
app/src/renderer/components/common/AppHeader.vue 93.75% <ø> (ø) ⬆️
app/src/renderer/vuex/getters.js 100% <ø> (ø) ⬆️
app/src/renderer/connectors/lcdClient.js 90.9% <100%> (-1.69%) ⬇️
app/src/renderer/vuex/modules/user.js 100% <100%> (ø) ⬆️
...rc/renderer/components/wallet/PageTransactions.vue 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/node.js 96.72% <100%> (-0.06%) ⬇️
app/src/renderer/vuex/modules/delegates.js 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/validators.js 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/wallet.js 95.38% <100%> (+0.07%) ⬆️
app/src/renderer/components/staking/PageBond.vue 100% <100%> (ø) ⬆️
... and 3 more

@fedekunze fedekunze self-requested a review August 10, 2018 17:10
@faboweb faboweb merged commit 028832a into develop Aug 13, 2018
@faboweb faboweb deleted the revert-1068-fedekunze/1010-lcd-stake branch August 13, 2018 07:34
faboweb added a commit that referenced this pull request Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants