Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: fixed delegations endpoint #1949

Merged
merged 3 commits into from
Aug 10, 2018
Merged

Conversation

faboweb
Copy link
Contributor

@faboweb faboweb commented Aug 9, 2018

Issue #1945

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #1949 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1949   +/-   ##
========================================
  Coverage    64.87%   64.87%           
========================================
  Files          114      114           
  Lines         6836     6836           
========================================
  Hits          4435     4435           
  Misses        2119     2119           
  Partials       282      282

}

// success
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can avoid these redundant comments (success and write)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not part of this PR :/

@fedekunze fedekunze changed the title fixed delegations endpoint R4R: fixed delegations endpoint Aug 10, 2018
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, perhaps we should have testcases which cover this but let's merge the fix in any case

I don't think this needs a changelog entry since the bug should never enter a release assuming we merge between 0.24.

@cwgoes cwgoes merged commit 1479a35 into develop Aug 10, 2018
@cwgoes cwgoes deleted the fabo/1945-fix-delegations-endpoint branch August 10, 2018 13:41
@cwgoes cwgoes mentioned this pull request Aug 13, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants