-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: fixed delegations endpoint #1949
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1949 +/- ##
========================================
Coverage 64.87% 64.87%
========================================
Files 114 114
Lines 6836 6836
========================================
Hits 4435 4435
Misses 2119 2119
Partials 282 282 |
x/stake/client/rest/query.go
Outdated
} | ||
|
||
// success |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can avoid these redundant comments (success and write)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was not part of this PR :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, perhaps we should have testcases which cover this but let's merge the fix in any case
I don't think this needs a changelog entry since the bug should never enter a release assuming we merge between 0.24.
Issue #1945
docs/
)PENDING.md
that include links to the relevant issue or PR that most accurately describes the change.cmd/gaia
andexamples/
For Admin Use: