Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error fetching validator set #1080

Closed
NodeGuy opened this issue Aug 6, 2018 · 15 comments
Closed

Error fetching validator set #1080

NodeGuy opened this issue Aug 6, 2018 · 15 comments
Assignees
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 6, 2018

UI Version: 0.9.3

Description:

Before I sign in, the error message "Error fetching validator set: Internal error" is displayed.

screen shot 2018-08-06 at 12 14 06 pm

I don't see anything significant in either console.

@NodeGuy NodeGuy added bug 🐛 issues related to unhandled errors in the code that need to be fixed discuss labels Aug 6, 2018
@jbibla
Copy link
Collaborator

jbibla commented Aug 7, 2018

it's odd that we are making requests before the user is signed in

@nylira
Copy link
Contributor

nylira commented Aug 7, 2018

Can we turn session modals into pages in vue-router instead of a z-index overlay on top of the wallet?

@faboweb
Copy link
Collaborator

faboweb commented Aug 8, 2018

@nylira can you create an issue recommending this change?

@faboweb
Copy link
Collaborator

faboweb commented Aug 8, 2018

I think this is a strange typo issue /stake/validators/ vs /stake/validators and I experienced it as well in #1068 . It will hopefully be resolved after this is merged.

@faboweb faboweb added the blocked ✋ issues blocked by other implementations/issues label Aug 13, 2018
@faboweb
Copy link
Collaborator

faboweb commented Aug 15, 2018

Assumed fixed

@faboweb faboweb closed this as completed Aug 15, 2018
@faboweb
Copy link
Collaborator

faboweb commented Aug 29, 2018

Still an issue

@faboweb faboweb reopened this Aug 29, 2018
@NodeGuy
Copy link
Contributor Author

NodeGuy commented Aug 29, 2018

What's blocking it?

@faboweb faboweb removed the blocked ✋ issues blocked by other implementations/issues label Aug 29, 2018
@faboweb
Copy link
Collaborator

faboweb commented Aug 29, 2018

the blocking label was still on there

@NodeGuy NodeGuy self-assigned this Aug 30, 2018
@NodeGuy
Copy link
Contributor Author

NodeGuy commented Aug 30, 2018

I can't reproduce it. @faboweb are you able to reproduce it consistently?

@NodeGuy NodeGuy removed their assignment Aug 30, 2018
@faboweb
Copy link
Collaborator

faboweb commented Aug 31, 2018

Not consistently but it happens from time to time.
"maybeUpdateValidators" is definitely called before having signed in. Which is probably OK to already fetch non user related data in the background.
I could imagine that this happens when we connect to a node and then quickly disconnect from that node again for any reason.

@NodeGuy
Copy link
Contributor Author

NodeGuy commented Aug 31, 2018

So what's the desired behavior? Should getValidators be called only when connected to a node or should we suppress the error message?

@faboweb
Copy link
Collaborator

faboweb commented Sep 3, 2018

Both seem to be valid options. Maybe we need to defer REST calls a little bit, so we are sure the connected node is working and we wont reconnect. This would solve the root cause.

@faboweb
Copy link
Collaborator

faboweb commented Sep 3, 2018

I handle the case "skipping it" in #1216

@fedekunze
Copy link
Contributor

Created #1313 to turn the session modals to pages

@faboweb
Copy link
Collaborator

faboweb commented Sep 18, 2018

The rpc subscription starts before the REST client is up. The headers come in and trigger a load of the validators before the the REST server is up. This creates this issue.

Current patch: Do not load data before the user is not signed in (which should be after the REST server is up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

No branches or pull requests

5 participants