Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking sections self DDoSes #879

Closed
okwme opened this issue Jun 25, 2018 · 6 comments · Fixed by #1121
Closed

Staking sections self DDoSes #879

okwme opened this issue Jun 25, 2018 · 6 comments · Fixed by #1121
Assignees
Labels
blocked ✋ issues blocked by other implementations/issues

Comments

@okwme
Copy link
Contributor

okwme commented Jun 25, 2018

UI Version: 0.7.0

Description: Polling each validator for amount of user's stake DDoSes the LCD and often crashes gaia causing a reconnect. This happens on mounted event for the staking page as well as wallet page with the action updateDelegates.

@mappum
Copy link
Contributor

mappum commented Jul 10, 2018

Update LCD to make it possible to do this in one combined request

@fedekunze
Copy link
Contributor

@faboweb This could effectively be resolved by changing the endpoints we are using (latest delegator set + delegations for each of the address, which is what makes voyager self DDoS) for
GET /stake/validators and
GET /stake/delegators/{delegatorAddr}/validators which is currently on hold by cosmos-sdk/1939.
I'll start working on it since it's a priority as discussed with @okwme .

@faboweb
Copy link
Collaborator

faboweb commented Aug 10, 2018

isn't this resolved by #1068 ?

@fedekunze
Copy link
Contributor

No, since it's still querying every delegation instead of the delegator's validators

@fedekunze
Copy link
Contributor

fedekunze commented Aug 10, 2018

@faboweb this will reduce the requests to just 2 instead of running a for loop though all the addresses of the latest validator set to ask if there's a delegation

@faboweb
Copy link
Collaborator

faboweb commented Aug 10, 2018

In #1068 it is implemented like that:

  • query all delegations a delegator has via one call to /stake/delegators/{addr}
  • query all candidates via one call to /stake/validators
  • map delegations to candidats

Am I missing something?

@faboweb faboweb added the blocked ✋ issues blocked by other implementations/issues label Aug 13, 2018
faboweb pushed a commit that referenced this issue Jun 6, 2020
* Add timeout to GH actions workflows

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked ✋ issues blocked by other implementations/issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants