Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply staking refactoring #1121

Merged
merged 4 commits into from
Aug 14, 2018
Merged

Reapply staking refactoring #1121

merged 4 commits into from
Aug 14, 2018

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Aug 13, 2018

Closes #879, #355, #1102

Description:

❤️ Thank you!

@faboweb faboweb requested review from NodeGuy and nylira as code owners August 13, 2018 08:27
@faboweb faboweb added the blocked ✋ issues blocked by other implementations/issues label Aug 13, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Aug 13, 2018

Wait for gaia-8000

@fedekunze
Copy link
Contributor

@faboweb does this addresses #1042 as well ?

@faboweb
Copy link
Collaborator Author

faboweb commented Aug 13, 2018

I think yes. We refactored the staking endpoints so that there is not "fractions" anymore. It is just floating point numbers delivered from the LCD.

@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #1121 into develop will decrease coverage by 1.13%.
The diff coverage is 78.64%.

@@             Coverage Diff             @@
##           develop    #1121      +/-   ##
===========================================
- Coverage    97.18%   96.05%   -1.14%     
===========================================
  Files           79       81       +2     
  Lines         1525     1595      +70     
  Branches        77       79       +2     
===========================================
+ Hits          1482     1532      +50     
- Misses          36       56      +20     
  Partials         7        7
Impacted Files Coverage Δ
app/src/renderer/components/common/AppHeader.vue 93.75% <ø> (ø) ⬆️
app/src/renderer/vuex/getters.js 100% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/wallet.js 95.31% <ø> (-0.08%) ⬇️
app/src/renderer/vuex/modules/delegates.js 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/delegation.js 100% <100%> (ø) ⬆️
app/src/renderer/connectors/lcdClient.js 92.59% <100%> (+1.68%) ⬆️
app/src/renderer/vuex/modules/node.js 96.77% <100%> (+0.05%) ⬆️
app/src/renderer/vuex/store.js 100% <100%> (ø) ⬆️
app/src/renderer/connectors/lcdClientMock.js 97.43% <100%> (+2.24%) ⬆️
app/src/renderer/vuex/modules/validators.js 100% <100%> (ø) ⬆️
... and 7 more

@faboweb
Copy link
Collaborator Author

faboweb commented Aug 14, 2018

As discussed with Billy I reapply these changes now. They will not work with Gaia-7005!

@faboweb faboweb merged commit be35a2c into develop Aug 14, 2018
@faboweb faboweb deleted the fabo/staking-refactor-reapply branch August 14, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked ✋ issues blocked by other implementations/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staking sections self DDoSes
2 participants