Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators with non-whole fractions of steaks showing incorrectly in staking window #1042

Closed
KamuelBob opened this issue Jul 29, 2018 · 2 comments · Fixed by #1148
Closed
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@KamuelBob
Copy link

UI Version: 0.9.1 Windows

Description:

Validators with non-whole fractions of steaks are showing the incorrect amount in the Staking window of Voyager.

image

Querying the above two validators in the Explorer shows that they should have 135.9 and 126.9 steaks respectively.

image

image

While this looks like the decimal place is not being handled correctly, another validator (#kingnet.com) is showing as 432 steak when according to the Explorer they have 86.4 (out by factor of 5 instead of 10).

The percent of vote is being calculated off the incorrect Total Votes, so I'm guessing this will be resolved once the votes is fixed.

Feel free to open Voyager v0.9.1 Windows on live testnet (gaia-7003) to view the same results.

@KamuelBob
Copy link
Author

Only had a quick chance to have a look, but appears to be the way it is expecting only integers somewhere here:
https://github.com/cosmos/voyager/blob/develop/app/src/renderer/components/staking/PageStaking.vue#L72

@faboweb
Copy link
Collaborator

faboweb commented Jul 29, 2018

Awesome bug report. We will follow up quickly.

@faboweb faboweb added bug 🐛 issues related to unhandled errors in the code that need to be fixed discuss labels Jul 30, 2018
@nylira nylira removed the discuss label Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants