update #8
Merged
update #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyelong
commented
Jul 11, 2018
zhangyelong
commented
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG.md
- Updated Gaia/Examples
- Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
* added async functionality to gaiacli * addressed requested changes, updated changelog
Bucky aditya/docs core
gaiadebug: support bech32
This linter ensures that all errors are checked. This is disabled in the client directories, since its not needed on those writes
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK Adds support for Ledger into gaiacli Cherry-picks updated error handling from #1158
docs via example apps
This is done so that the time spent on bcrypt during test cases can be reduced. This change reduces the amount of time lcd tests spend on bcrypt from 76% to 40%. (We need to reduce the number of calls to bcrypt in a seperate PR, along with fixing other sources of slowness) Making the bcrypt security parameter a var shouldn't be a security issue: One can't verify an invalid key by maliciously changing the bcrypt parameter during a runtime vulnerability. The main security threat this then exposes would be something that changes this during runtime before the user creates their key. This vulnerability must succeed to update this to that same value before every subsequent call to gaiacli keys in future startups / or the attacker must get access to the filesystem. However, with this same threat model (changing variables in runtime), one can cause the user to sign a different tx than what they see, which is a significantly cheaper attack then breaking a bcrypt hash. (Recall that the nonce still exists to break rainbow tables)
This adds a command to automatically fix gofmt and misspell errors.
* x/stake: Limit the size of rationals from user input This commit sets the maximum number of decimal points that can be passed in from messages. This is enforced on the validate basic of MsgBeginUnbonding and MsgBeginRedelegation. The cli has been updated to truncate the user input to the specified precision. This also updates types/rational to return big ints for Num() and Den(). Closes #887 * Switch NewFromDecimal to error instead of truncating
fix lint apply requests revert removing newCtx refactor fix errors
Cleanup Baseapp
changelog: Reorder items in the changelog
Add Gov cmds for Gaia-7000
* adding option functions to baseapp constructor * Added simple test and changed godoc * remove unrelated changelog updates
Release/v0.20.0
… behalf of genesis validator * Added msg and handling for surrogate create validator * changelog and error fix * fix changelog * Remove unnecessary msg by combining into CreateValidator * Refactor * Appease linter * Added onbehalfof functionality in client * fmt * Added gaia onbehalfof test * Update test for onbehalfof validator creation * fix test * Fix flag error * Add app test * fmt * Fixed signer for onbehalfof createvalidator * Fix error msg * Simplify test * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.