Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Use new tmlibs/common.Error for sdk.Error #1158

Closed
wants to merge 1 commit into from

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Jun 7, 2018

@jaekwon jaekwon requested a review from ebuchman as a code owner June 7, 2018 10:24
@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

Merging #1158 into develop will decrease coverage by 0.01%.
The diff coverage is 46.15%.

@@             Coverage Diff             @@
##           develop    #1158      +/-   ##
===========================================
- Coverage    61.07%   61.05%   -0.02%     
===========================================
  Files           89       89              
  Lines         4393     4391       -2     
===========================================
- Hits          2683     2681       -2     
  Misses        1538     1538              
  Partials       172      172

@ebuchman ebuchman added the wip label Jun 15, 2018
@ebuchman ebuchman mentioned this pull request Jun 25, 2018
cwgoes added a commit that referenced this pull request Jun 29, 2018
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK
Adds support for Ledger into gaiacli
Cherry-picks updated error handling from #1158
@ValarDragon
Copy link
Contributor

Closed by #931 cherry-picking this

adrianbrink pushed a commit that referenced this pull request Jul 2, 2018
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK
Adds support for Ledger into gaiacli
Cherry-picks updated error handling from #1158
@zramsay zramsay deleted the jae/errors_simplification branch November 30, 2018 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants