Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor types/errors.go to use tmlibs/common/errors.go #635

Closed
jaekwon opened this issue Mar 17, 2018 · 6 comments
Closed

Refactor types/errors.go to use tmlibs/common/errors.go #635

jaekwon opened this issue Mar 17, 2018 · 6 comments

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Mar 17, 2018

I moved the general function of tracing error logic into tmlibs/common/errors.go.
sdkError should probably anonymously embed the tmlibs error, so we don't duplicate logic,
and we can make sure tmlibs/common/errors.go is well designed enough to be extended.
@cwgoes
Copy link
Contributor

cwgoes commented Apr 27, 2018 •
edited
Loading

Anything further necessary beyond what was implemented in #809?

@cwgoes cwgoes added this to the 1.0 Code Freeze milestone Apr 27, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Jun 26, 2018

Possibly superseded by #1158.

@ValarDragon
Copy link
Contributor

Confirmed with Jae, it is resolved by #1158.

@ebuchman
Copy link
Member

Note I cherry-picked that for the 0.19.1 release

@liamsi
Copy link
Contributor

liamsi commented Jun 26, 2018 •
edited
Loading

Note I cherry-picked that for the 0.19.1 release

That helps with the repo consolidation, too. As IAVL and go-amino depend on latest tmlibs, too. We need to rebase #931 these changes, too (cc @cwgoes)

@ValarDragon
Copy link
Contributor

Closed by #931 merging #1158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jaekwon @ebuchman @ValarDragon @liamsi @cwgoes