Ledger integration #931
Merged
Ledger integration #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nano Support
Fixes tendermint/go-crypto#43 Avoid susceptibility to timing/side channel attacks by ensuring that private key and signature comparisons use `subtle.ConstantTimeCompare` instead of `bytes.Equal`
Bcrypt usability
Bugfix: ledger nano/hid compiles on osx/golang1.9
This reverts commit dfc4cdd.
This reverts commit 8e7f0e7.
Release v0.4.1
Fixes tendermint/go-crypto#48. This previously skewed up my fuzzing tests so ensure that on error we return the zero value PubKey.
…pty-pubKey PubKeyFromBytes: return zero value PubKey on error
…sdk into cwgoes/ledger-integration
cwgoes
force-pushed
the
cwgoes/ledger-integration
branch
from
2db4edf to
03459a7
Compare
|
For reasons unknown the linter is linting a file in |
|
idk whats going on there either, --vendor is eliminating the rest of the output for the vendors directory |
cwgoes
force-pushed
the
cwgoes/ledger-integration
branch
from
e86a284 to
22414b3
Compare
ValarDragon
previously approved these changes
Jun 29, 2018
| // Only need a passphrase for locally-stored keys | ||
| if info.GetType() == "local" { | ||
| passphrase, err = ctx.GetPassphraseFromStdin(name) | ||
| if err != nil { |
There was a problem hiding this comment.
This should be done through an enum type, or something similar, and have associated method "getPassphrase from stdin". Doesn't block this PR.
| @@ -32,10 +36,13 @@ If you select --seed/-s you can recover a key from the seed | |||
| phrase, otherwise, a new key will be generated.`, | |||
| RunE: runAddCmd, | |||
| } | |||
| cmd.Flags().StringP(flagType, "t", "ed25519", "Type of private key (ed25519|secp256k1|ledger)") | |||
| cmd.Flags().StringP(flagType, "t", "secp256k1", "Type of private key (secp256k1|ed25519)") | |||
There was a problem hiding this comment.
default changing from ed25519 intentional?
ValarDragon
previously approved these changes
Jun 29, 2018
cwgoes
force-pushed
the
cwgoes/ledger-integration
branch
from
c31df61 to
2150b33
Compare
ValarDragon
approved these changes
Jun 29, 2018
This was referenced Jun 29, 2018
Closed
adrianbrink
pushed a commit
that referenced
this pull request
Jul 2, 2018
Merges the keybase and Ledger code from go-crypto (which is no more) into the SDK Adds support for Ledger into gaiacli Cherry-picks updated error handling from #1158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gaiacliCloses #1117
Mostly blocked on finalization of #1119Merged!Wants tendermint/tendermint#1803, but doesn't need to block merge