Update README for n00bs #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
reviewed
Mar 1, 2017
README.md
Outdated
| ## Prerequisites | ||
|
|
||
| * Go to https://golang.org/doc/install to install Golang. | ||
| * Once you have Golang installed you will also need to install the Golang package manager `glide`: https://github.com/Masterminds/glide. |
There was a problem hiding this comment.
This is somewhat optional (if go get fails or the dev wants fixed versions)
There was a problem hiding this comment.
go get succeeded but i wasn't able to run make get_vendor_deps without glide, i got this error:
/go/src/github.com/tendermint/basecoin (develop) $ make get_vendor_deps
go get github.com/Masterminds/glide
glide install
make: glide: No such file or directory
make: *** [get_vendor_deps] Error 1
There was a problem hiding this comment.
there is no need to make get_vendor_deps if go get -u .../cmd/basecoin succeeded.
There was a problem hiding this comment.
in that case I think we need to change the instructions here:
The guaranteed correct way of compiling from source, assuming you've already run go get or otherwise cloned the repo, is:
git checkout develop # (until we release tendermint v0.9)
make get_vendor_deps
make install
because it seems like once you do go get you're supposed to do all that stuff ^^. How would you change it?
liamsi
pushed a commit
to liamsi/cosmos-sdk
that referenced
this pull request
Jun 26, 2018
Release v0.4.1
joe-bowman
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Mar 3, 2020
… reward post withdraw (fixes cosmos#47)
joe-bowman
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 17, 2020
… reward post withdraw (fixes cosmos#47)
RevelationOfTuring
referenced
this pull request
in okx/cosmos-sdk
Apr 20, 2020
This was referenced Apr 20, 2020
zhongqiuwood
referenced
this pull request
in okx/cosmos-sdk
Apr 27, 2020
* okchain patch * Change system fee to gas fee * remove minimum-gas-prices from the server/start.go * fix backend default config * Remove some meaningless comments and some default value of flags * fix the mock test func * set defaultMinGasPrices = "0.00000001okt" * FIX: issue #47, remove param msdLimited in config/default_params.go * add fee * Update query.go change client tips from cosmosxxx to okchainxxx * open CI and fix UT (#12) * Update config.yml * udpate go mod * Update config.yml * fix UT * fix UT * fix UT * fix UT * fix UT * fix UT * fix UT * fix UT * fix slashing UT * Update config.yml * cancel TxMsgs limit, revert to version cosmos * Update config.yml * Update config.yml * Update config.yml * Update README.md Co-authored-by: ylsGit <> Co-authored-by: yezhigang <[email protected]> * To fix okchain issue #70 && order tx not requiring fees (#10) * set the Infinite Gas Meter for order tx Co-authored-by: GeYiLi <[email protected]> Co-authored-by: liuxiong <[email protected]> Co-authored-by: yanwei.han <[email protected]> Co-authored-by: qzhongwood <[email protected]> Co-authored-by: MichaelWang <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: ZhiGang <[email protected]> Co-authored-by: ylsGit <[email protected]> Co-authored-by: yezhigang <[email protected]> Co-authored-by: banishee <[email protected]> Co-authored-by: GeYiLi <[email protected]>
joeabbey
referenced
this pull request
in joeabbey/cosmos-sdk
Jan 21, 2022
Raumo0
pushed a commit
to mapofzones/cosmos-sdk
that referenced
this pull request
Feb 13, 2022
Thunnini
referenced
this pull request
in Thunnini/cosmos-sdk
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I followed the instructions and wrote down all the things that I had to do to get there
glide$GOPATHenv varSteps to test
Notes
This means
basecoin starthas succeeded (apparently) but the messaging is unclear. Should we add a note in the README to decipher it, or should we change the messaging?