Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the default denom to mycoin #42

Closed
wants to merge 1 commit into from
Closed

Changed the default denom to mycoin #42

wants to merge 1 commit into from

Conversation

phomer
Copy link

@phomer phomer commented Feb 25, 2017

Set the default denom to mycoin, so that the tutorial tx send works without specifying denomination.

@rigelrozanski
Copy link
Contributor

Where in the tutorial was the error being generated? I thought that within all the of the tutorials it now in the form --fee 1mycoin and nolonger --fee 1 --denom mycoin I'm concerned with the idea of not specifiying the denom within the tutorial I think that's a concept we want to introduce right from the get-go, maybe a better explaination of multi-coin abilities of basecoin in the tutorial is more appropriate that modifying this code to assume which coin you want to use if you haven't specified one. Just and idea, thoughts?

@phomer
Copy link
Author

phomer commented Feb 26, 2017

Sorry Rigel, it was my mistake. I was looking at the master versions, not develop. Github newbie mistake...

@phomer phomer closed this Feb 26, 2017
@phomer phomer deleted the mycoin-fix branch March 2, 2017 17:09
liamsi pushed a commit to liamsi/cosmos-sdk that referenced this pull request Jun 26, 2018
aleem1314 pushed a commit to aleem1314/cosmos-sdk that referenced this pull request Sep 2, 2021
…nt-locked-acct-msg

feat!: add MsgCreatePermanentLockedVestingAccount
amaury1093 pushed a commit that referenced this pull request Nov 4, 2021
* Merge pull request #42 from regen-network/clevinson/add-permanent-locked-acct-msg

feat!: add MsgCreatePermanentLockedVestingAccount

* fix changelog

Co-authored-by: Cory <[email protected]>
faddat referenced this pull request in notional-labs/cosmos-sdk Dec 3, 2021
* filtered simulation fee tokens to only use sdk.DefaultBondDenom

* fixed simulation
faddat referenced this pull request in notional-labs/cosmos-sdk Dec 18, 2021
* filtered simulation fee tokens to only use sdk.DefaultBondDenom

* fixed simulation
Raumo0 pushed a commit to mapofzones/cosmos-sdk that referenced this pull request Feb 13, 2022
Thunnini referenced this pull request in Thunnini/cosmos-sdk Feb 28, 2022
* filtered simulation fee tokens to only use sdk.DefaultBondDenom

* fixed simulation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants