Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #37

Merged
merged 3 commits into from
Feb 24, 2017
Merged

Unit tests #37

merged 3 commits into from
Feb 24, 2017

Conversation

rigelrozanski
Copy link
Contributor

NOTE this is branched from queryReg which is in the PR, should merge after PR #26

squash me

squash me

squash
Copy link
Member

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Main thing is to try and use more table driven testing

}

setRecords(s)
assert.True(t, bytes.Equal(s.Get([]byte("foo")), []byte("snake")), "state doesn't retrieve after Set")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would love to see a more table driven approach for a lot of these tests: https://dave.cheney.net/2013/06/09/writing-table-driven-tests-in-go

accCopy.Sequence = 1
t.Log(acc.Sequence)
t.Log(accCopy.Sequence)
assert.True(t, acc.Sequence != accCopy.Sequence, "Account Copy Error")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not check the accounts are equal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay switched. was confused because the pointer wasn't equal but that makes sense, not supposed to be.

@ebuchman ebuchman merged commit e6579cf into develop Feb 24, 2017
@ebuchman ebuchman deleted the unitTests branch March 6, 2017 10:00
liamsi pushed a commit to liamsi/cosmos-sdk that referenced this pull request Jun 26, 2018
ParthDesai pushed a commit to ChorusOne/cosmos-sdk that referenced this pull request Apr 19, 2021
Raumo0 pushed a commit to mapofzones/cosmos-sdk that referenced this pull request Feb 13, 2022
* Execute validator unbonding at consensus changeover

* Fix producing block status of genesis validators

* Add comments
inon-man pushed a commit to classic-terra/cosmos-sdk that referenced this pull request Feb 21, 2023
…ns/actions/cache-3.0.1

chore(deps): bump actions/cache from 2.1.6 to 3.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants