CLI Updates, Coin fix #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
force-pushed
the
queryReg
branch
from
b2e596f to
4699f33
Compare
rigelrozanski
force-pushed
the
queryReg
branch
from
78f36dd to
a83801c
Compare
ebuchman
reviewed
Feb 10, 2017
cmd/commands/query.go
Outdated
| @@ -66,6 +66,11 @@ var ( | |||
| } | |||
| ) | |||
|
|
|||
| // Register a subcommand of TxCmd to craft transactions for plugins | |||
ebuchman
reviewed
Feb 10, 2017
cmd/commands/utils.go
Outdated
| @@ -35,6 +39,46 @@ func StripHex(s string) string { | |||
| return s | |||
| } | |||
|
|
|||
| func ParseCoin(str string) (types.Coin, error) { | |||
There was a problem hiding this comment.
fix so ParseCoins calls ParseCoin, not the other way round
ebuchman
reviewed
Feb 10, 2017
| @@ -58,7 +102,7 @@ func Query(tmAddr string, key []byte) (*abci.ResponseQuery, error) { | |||
| // fetch the account by querying the app | |||
| func getAcc(tmAddr string, address []byte) (*types.Account, error) { | |||
|
|
|||
| key := append([]byte("base/a/"), address...) | |||
| key := state.AccountKey(address) | |||
ebuchman
reviewed
Feb 10, 2017
| @@ -69,12 +69,12 @@ func (ep *ExamplePlugin) RunTx(store types.KVStore, ctx types.CallContext, txByt | |||
| return abci.OK | |||
| } | |||
|
|
|||
| func (ep *ExamplePlugin) InitChain(store types.KVStore, vals []*abci.Validator) { | |||
| func (cp *ExamplePlugin) InitChain(store types.KVStore, vals []*abci.Validator) { | |||
There was a problem hiding this comment.
cp ? let's keep it ep for this example plugin. Thanks for fixing the methods though
|
Great stuff. Do the guides need to be updated for the new coins format though? Can you add that here? |
|
@ebuchman Yes I will investigate / update the guides for the new CLI format |
rigelrozanski
force-pushed
the
queryReg
branch
from
5961056 to
49c3ab0
Compare
|
Can we change all the Also, can we get some simple tests for the ParseCoin? |
whoops
rigelrozanski
force-pushed
the
queryReg
branch
from
b8a94f7 to
6a21ad5
Compare
Merged
liamsi
pushed a commit
to liamsi/cosmos-sdk
that referenced
this pull request
Jun 26, 2018
hd: optimize ReverseBytes + add tests
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
Raumo0
pushed a commit
to mapofzones/cosmos-sdk
that referenced
this pull request
Feb 13, 2022
luchenqun
pushed a commit
to luchenqun/cosmos-sdk
that referenced
this pull request
Sep 29, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24
closes #27
added query subcommand register
modified the CLI to allow for multiple coin types sending to the transaction
fix Coin.IsGTE logic