docs: Fix dependencies, from monorepo merge #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1463 +/- ##
========================================
Coverage 63.18% 63.18%
========================================
Files 118 118
Lines 6554 6554
========================================
Hits 4141 4141
Misses 2144 2144
Partials 269 269 |
zramsay
reviewed
Jul 2, 2018
| [the | ||
| specification](https://github.com/tendermint/abci/blob/master/specification.md) | ||
| specification](https://github.com/tendermint/tendermint/abci/blob/master/specification.md) |
There was a problem hiding this comment.
404 but i'll fix in tendermint/tendermint#1847 because it won't be at ^ this location
link should be REPO/blob/master/abci/spec
zramsay
reviewed
Jul 2, 2018
|
|
||
| ## Slashing | ||
|
|
||
| Tendermint blocks can include | ||
| [Evidence](https://github.com/tendermint/tendermint/blob/develop/docs/spec/blockchain/blockchain.md#evidence), which indicates that a validator | ||
| committed malicious behaviour. The relevant information is forwarded to the | ||
| application as [ABCI | ||
| Evidence](https://github.com/tendermint/abci/blob/develop/types/types.proto#L259), so the validator an be accordingly punished. | ||
| Evidence](https://github.com/tendermint/tendermint/abci/blob/develop/types/types.proto#L259), so the validator an be accordingly punished. |
There was a problem hiding this comment.
same deal:
https://github.com/tendermint/tendermint/blob/develop/abci/types/types.proto#L259
is the correct link
zramsay
reviewed
Jul 2, 2018
| @@ -256,7 +256,7 @@ Accounts are serialized and stored in a Merkle tree under the key | |||
| Typically, the address of the account is the 20-byte ``RIPEMD160`` hash | |||
| of the public key, but other formats are acceptable as well, as defined | |||
| in the `Tendermint crypto | |||
| library <https://github.com/tendermint/go-crypto>`__. The Merkle tree | |||
| library <https://github.com/tendermint/tendermint/crypto>`__. The Merkle tree | |||
zramsay
reviewed
Jul 2, 2018
| @@ -189,7 +189,7 @@ docs](https://godoc.org/github.com/cosmos/cosmos-sdk/types#Context) for more det | |||
| ### Result | |||
|
|
|||
| Handler takes a Context and Msg and returns a Result. | |||
| Result is motivated by the corresponding [ABCI result](https://github.com/tendermint/abci/blob/master/types/types.proto#L165). | |||
| Result is motivated by the corresponding [ABCI result](https://github.com/tendermint/tendermint/abci/blob/master/types/types.proto#L165). | |||
zramsay
reviewed
Jul 2, 2018
| @@ -409,11 +409,11 @@ func txDecoder(txBytes []byte) (sdk.Tx, sdk.Error) { | |||
| Finally, we stitch it all together using the `BaseApp`. | |||
|
|
|||
| The BaseApp is an abstraction over the [Tendermint | |||
| ABCI](https://github.com/tendermint/abci) that | |||
| ABCI](https://github.com/tendermint/tendermint/abci) that | |||
There was a problem hiding this comment.
404, need blob/master in there
zramsay
reviewed
Jul 2, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1456
Updated all code comments where relevantWrote testsUpdated CHANGELOG.mdUpdated Gaia/Examples