Cleanup Baseapp #1400
Merged
Cleanup Baseapp #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossid
force-pushed
the
joon/1329-cleanup-baseapp
branch
from
d5e3d54 to
2101459
Compare
mossid
force-pushed
the
joon/1329-cleanup-baseapp
branch
from
2101459 to
7c23cef
Compare
mossid
added a commit
that referenced
this pull request
Jun 27, 2018
Codecov Report
@@ Coverage Diff @@
## develop #1400 +/- ##
===========================================
+ Coverage 63.66% 63.67% +0.01%
===========================================
Files 122 122
Lines 6764 6766 +2
===========================================
+ Hits 4306 4308 +2
Misses 2213 2213
Partials 245 245 |
|
Dependent on tendermint/tendermint#1803 |
ebuchman
reviewed
Jul 5, 2018
baseapp/baseapp.go
Outdated
| @@ -505,17 +447,17 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte, tx sdk.Tx) (result sdk | |||
|
|
|||
| // Run the ante handler. | |||
| if app.anteHandler != nil { | |||
| newCtx, result, abort := app.anteHandler(ctx, tx) | |||
| var newCtx sdk.Context | |||
There was a problem hiding this comment.
should the ante handler really get an empty context? why not the ctx we already populated above?
There was a problem hiding this comment.
Tried to modify it, and the test failed :( I don't know why does it affect to the execution but we cannot change it.
mossid
force-pushed
the
joon/1329-cleanup-baseapp
branch
from
0264619 to
fca7277
Compare
mossid
force-pushed
the
joon/1329-cleanup-baseapp
branch
from
fca7277 to
ea9ca6f
Compare
mossid
added a commit
that referenced
this pull request
Jul 5, 2018
fix lint apply requests revert removing newCtx
|
Decided to skip codespace removing |
mossid
force-pushed
the
joon/1329-cleanup-baseapp
branch
from
a1e6bb8 to
31b9007
Compare
mossid
added a commit
that referenced
this pull request
Jul 9, 2018
fix lint apply requests revert removing newCtx refactor fix errors
|
I'll fix and merge this thanks jooN! |
ebuchman
force-pushed
the
joon/1329-cleanup-baseapp
branch
from
31b9007 to
4761612
Compare
fix lint apply requests revert removing newCtx refactor fix errors
ebuchman
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1329