Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/metamask connection #4211

Closed
wants to merge 62 commits into from
Closed

Fix/metamask connection #4211

wants to merge 62 commits into from

Conversation

octavioamu
Copy link
Contributor

Revert changes from a2e3804#diff-9bd96a6d2da4e99c0d1b9e27c7ead8b9R461

since this break metamask in any browser and for opera last version the web3 injection is minimal just to see the address, so need to load web3.js. Also there are a few diff
when sending a tx need go specify the field "from" (metamask didn't need that)
Also wallet api in opera works as others browser apis need the ask for permission to access or is not going to work (like metamask.enable() ) in opera need to run web3.currentProvider.enable() to and approve the permission, but there is not injection to expose the wallet without loading web3.js

This PR just fix the isBountyOwner returning always false.

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@octavioamu octavioamu changed the base branch from master to stable April 16, 2019 23:41
}
if (typeof web3.eth.coinbase == 'undefined' || !web3.eth.coinbase) {

if (!web3.eth || typeof web3.eth.coinbase == 'undefined' || !web3.eth.coinbase) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (typeof web3 == 'undefined' || !web3.eth ||...) {

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #4211 into stable will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           stable    #4211   +/-   ##
=======================================
  Coverage   30.28%   30.28%           
=======================================
  Files         209      209           
  Lines       16594    16594           
  Branches     2220     2220           
=======================================
  Hits         5025     5025           
  Misses      11389    11389           
  Partials      180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e3804...b295b53. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #4211 into stable will decrease coverage by 0.14%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #4211      +/-   ##
==========================================
- Coverage   30.28%   30.13%   -0.15%     
==========================================
  Files         209      209              
  Lines       16605    16743     +138     
  Branches     2223     2273      +50     
==========================================
+ Hits         5028     5046      +18     
- Misses      11397    11513     +116     
- Partials      180      184       +4
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/dashboard/models.py 55.74% <ø> (-0.26%) ⬇️
app/kudos/views.py 21.84% <0%> (-0.14%) ⬇️
app/event_ethdenver2019/views.py 18.6% <0%> (-0.45%) ⬇️
app/kudos/models.py 56.92% <100%> (+0.44%) ⬆️
app/dashboard/views.py 13.71% <12.5%> (-0.1%) ⬇️
app/retail/views.py 29.6% <25%> (-0.07%) ⬇️
app/grants/views.py 15.59% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402af64...e961396. Read the comment docs.

@thelostone-mc thelostone-mc force-pushed the fix/metamask-connection branch from b295b53 to 9de1cfc Compare April 23, 2019 15:36
@octavioamu octavioamu force-pushed the fix/metamask-connection branch from 9de1cfc to fe43563 Compare April 23, 2019 16:20
@thelostone-mc
Copy link
Member

Moving this check over to master

@thelostone-mc thelostone-mc mentioned this pull request Apr 24, 2019
@thelostone-mc thelostone-mc deleted the fix/metamask-connection branch July 4, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants