-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/metamask connection #4211
Fix/metamask connection #4211
Conversation
Adds the jobs page, with new icons and django view. Adds jobs to footer under Business heading.
} | ||
if (typeof web3.eth.coinbase == 'undefined' || !web3.eth.coinbase) { | ||
|
||
if (!web3.eth || typeof web3.eth.coinbase == 'undefined' || !web3.eth.coinbase) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (typeof web3 == 'undefined' || !web3.eth ||...) {
fix test and style
Add jobs page
fix condition after onboard
fix sidebar hackathon
Fix/hackathon issues
Payout crowdfund
Issue 3699 popover quick glance
check for undefined web3 coinbase
Codecov Report
@@ Coverage Diff @@
## stable #4211 +/- ##
=======================================
Coverage 30.28% 30.28%
=======================================
Files 209 209
Lines 16594 16594
Branches 2220 2220
=======================================
Hits 5025 5025
Misses 11389 11389
Partials 180 180 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable #4211 +/- ##
==========================================
- Coverage 30.28% 30.13% -0.15%
==========================================
Files 209 209
Lines 16605 16743 +138
Branches 2223 2273 +50
==========================================
+ Hits 5028 5046 +18
- Misses 11397 11513 +116
- Partials 180 184 +4
Continue to review full report at Codecov.
|
b295b53
to
9de1cfc
Compare
9de1cfc
to
fe43563
Compare
…a sender pk and sender address that will pay the gas
Moving this check over to |
Revert changes from a2e3804#diff-9bd96a6d2da4e99c0d1b9e27c7ead8b9R461
since this break metamask in any browser and for opera last version the web3 injection is minimal just to see the address, so need to load web3.js. Also there are a few diff
when sending a tx need go specify the field "from" (metamask didn't need that)
Also wallet api in opera works as others browser apis need the ask for permission to access or is not going to work (like metamask.enable() ) in opera need to run web3.currentProvider.enable() to and approve the permission, but there is not injection to expose the wallet without loading web3.js
This PR just fix the isBountyOwner returning always false.
Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
make test
and everything passed!Reviewer
Funder