Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor code #4262

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Conversation

thelostone-mc
Copy link
Member

Description

Moving changes over from #4211 which was raised against stable

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #4262 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4262      +/-   ##
==========================================
- Coverage   30.22%   30.18%   -0.04%     
==========================================
  Files         209      209              
  Lines       16625    16625              
  Branches     2223     2223              
==========================================
- Hits         5025     5019       -6     
- Misses      11419    11425       +6     
  Partials      181      181
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b2417...f043e9c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #4262 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4262      +/-   ##
==========================================
- Coverage   30.22%   30.18%   -0.04%     
==========================================
  Files         209      209              
  Lines       16625    16625              
  Branches     2223     2223              
==========================================
- Hits         5025     5019       -6     
- Misses      11419    11425       +6     
  Partials      181      181
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b2417...f043e9c. Read the comment docs.

@danlipert danlipert merged commit d8282aa into gitcoinco:master Apr 24, 2019
@thelostone-mc thelostone-mc deleted the fix/metamask-connection branch April 24, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants