Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix condition after onboard #4210

Merged
merged 2 commits into from
Apr 23, 2019
Merged

fix condition after onboard #4210

merged 2 commits into from
Apr 23, 2019

Conversation

octavioamu
Copy link
Contributor

Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #4210 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4210      +/-   ##
==========================================
+ Coverage   30.37%   30.42%   +0.05%     
==========================================
  Files         206      206              
  Lines       16404    16404              
  Branches     2156     2156              
==========================================
+ Hits         4982     4991       +9     
+ Misses      11242    11231      -11     
- Partials      180      182       +2
Impacted Files Coverage Δ
app/dashboard/utils.py 36.9% <0%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977ad5d...0cb4908. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #4210 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4210   +/-   ##
=======================================
  Coverage   30.24%   30.24%           
=======================================
  Files         209      209           
  Lines       16606    16606           
  Branches     2223     2223           
=======================================
  Hits         5022     5022           
  Misses      11403    11403           
  Partials      181      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4902db3...32ddabc. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 007e6b8 into master Apr 23, 2019
@thelostone-mc thelostone-mc deleted the fix/hackathon-onboard branch April 23, 2019 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants