Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobs page #4079

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Add jobs page #4079

merged 3 commits into from
Apr 18, 2019

Conversation

emiwatanabe422
Copy link
Contributor

Adds the jobs page, with new icons and django view. Adds jobs to footer under Business heading.

Description

See #3931

Checklist
Affected core subsystem(s)

ui

Refers/Fixes

#3931

Testing and Sign-off

image
image
image
image

Contributor
  • [ x] Read and followed the Contributor Guidelines
  • [x ] Tested all changes locally
  • [x ] Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

Adds the jobs page, with new icons and django view. Adds jobs to footer under Business heading.
@owocki
Copy link
Contributor

owocki commented Apr 1, 2019

Design LGTM @PixelantDesign, if it looks good to you i can edit the copy so that it's no longer lorem ipsum. we'll probably also link it in the footer

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #4079 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4079      +/-   ##
==========================================
- Coverage   30.22%   30.22%   -0.01%     
==========================================
  Files         205      205              
  Lines       16236    16240       +4     
  Branches     2136     2136              
==========================================
+ Hits         4908     4909       +1     
- Misses      11154    11157       +3     
  Partials      174      174
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/retail/views.py 29.33% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a609fee...ce5b514. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #4079 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4079      +/-   ##
=========================================
- Coverage   30.22%   30.2%   -0.02%     
=========================================
  Files         205     209       +4     
  Lines       16236   16604     +368     
  Branches     2136    2222      +86     
=========================================
+ Hits         4908    5016     +108     
- Misses      11154   11407     +253     
- Partials      174     181       +7
Impacted Files Coverage Δ
app/retail/views.py 29.6% <ø> (+0.21%) ⬆️
app/app/urls.py 90% <ø> (ø) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️
app/marketing/mails.py 11.52% <0%> (-1.59%) ⬇️
app/grants/models.py 50.71% <0%> (-0.77%) ⬇️
app/retail/utils.py 10.48% <0%> (-0.7%) ⬇️
app/dashboard/utils.py 34.49% <0%> (-0.36%) ⬇️
app/dashboard/helpers.py 15.06% <0%> (-0.3%) ⬇️
app/retail/emails.py 21.52% <0%> (-0.29%) ⬇️
app/marketing/views.py 12% <0%> (-0.27%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a609fee...74c5040. Read the comment docs.

@emiwatanabe422
Copy link
Contributor Author

Noticed this button one the products page mentions jobs so it's now linked to the new jobs page.

image

Copy link
Contributor

@owocki owocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Anyone else?

@owocki owocki requested review from danlipert and octavioamu April 17, 2019 21:49
@owocki owocki merged commit df9bc8a into gitcoinco:master Apr 18, 2019
@emiwatanabe422 emiwatanabe422 deleted the jobs-page branch April 18, 2019 22:33
@emiwatanabe422
Copy link
Contributor Author

Hey @owocki, could I get paid out for this? Thanks!!

@owocki
Copy link
Contributor

owocki commented Apr 25, 2019

sorry doing so now!

@owocki
Copy link
Contributor

owocki commented Apr 25, 2019

@emiwatanabe422 how much do i owe you? i dont see a gitcoin bounty for this and can't remember what we agreed upon :)

@emiwatanabe422
Copy link
Contributor Author

@owocki Maybe 2ETH? I don't think we discussed it before.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 2.00000 ETH (328.27 USD @ $164.13/ETH) has been granted to @emiwatanabe422 for this issue from @owocki. ⚡️

Nice work @emiwatanabe422! Your tip has automatically been deposited in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants