Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for undefined web3 coinbase #4250

Merged
merged 2 commits into from
Apr 23, 2019
Merged

check for undefined web3 coinbase #4250

merged 2 commits into from
Apr 23, 2019

Conversation

danlipert
Copy link
Contributor

@danlipert danlipert commented Apr 23, 2019

Description

This PR checks to see if the coinbase check returns undefined, which isn't unexpected behavior (the encapsulating function is waiting for the web3 client to be ready) but is causing our alert system to go crazy lately.

Refers/Fixes

No issue

Testing

Tested creating a grant and funding it with a recurring donation manually.

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #4250 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4250   +/-   ##
=======================================
  Coverage   30.24%   30.24%           
=======================================
  Files         209      209           
  Lines       16607    16607           
  Branches     2223     2223           
=======================================
  Hits         5022     5022           
  Misses      11404    11404           
  Partials      181      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75017c5...521c7ee. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #4250 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4250      +/-   ##
==========================================
+ Coverage   30.22%   30.24%   +0.01%     
==========================================
  Files         209      209              
  Lines       16619    16607      -12     
  Branches     2223     2223              
==========================================
- Hits         5023     5022       -1     
+ Misses      11415    11404      -11     
  Partials      181      181
Impacted Files Coverage Δ
app/app/urls.py 90% <0%> (ø) ⬆️
app/dashboard/models.py 55.74% <0%> (ø) ⬆️
app/dashboard/views.py 13.77% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc3616...0596597. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 0e32fc5 into master Apr 23, 2019
@thelostone-mc thelostone-mc deleted the undefined-coinbase branch July 4, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants