Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Front-End of Notifications for Gitcoin #2404

Closed
12 of 15 tasks
PixelantDesign opened this issue Oct 10, 2018 · 33 comments
Closed
12 of 15 tasks

Build Front-End of Notifications for Gitcoin #2404

PixelantDesign opened this issue Oct 10, 2018 · 33 comments
Assignees

Comments

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Oct 10, 2018

User Story

Why Is this Needed

Summary: Currently we email community members on things they need to act upon but there isn't a central place on Gitcoin that users can go to to view all notifications and take action.

Description

This task is to build the front-end of the notification system.

Definition of Done

  • Review the attached mockups and Gitcoin's contribution guidelines and front-end guidelines.
  • Add a way for users to access the notification dropdown (authenticated).
  • Users should not see the notification bell if anauthenticated.
  • A notification count should be displayed at the top of dropdown
  • User should be able to view top notifications in the dropdown.
  • From the menu users should be able to and click view all to see it all on a page.
  • Dropdown should not show items that have been read.
  • The dropdown should show a green dot to denote unread
  • See all view should show all notifications.
  • This should work in responsive views.
  • notifications can be selected or unselected. there will be 'select all' or 'deselect all' buttons on the top, and there will also be 'mark selected as read', 'delete selected' and 'mark selected all as unread' buttons'
  • notifications will be sorted chronologically and paginated
  • notifications can be marked as read, marked as unread, or deleted
  • when a user clicks on the notification will be marked as read and takes user to the appropriate issue.
  • PR is merged

Notifications will be generated each time a user needs to take action upon something (approve worker, disapprove worker, accept worker, receive tip, etc)

Here are the potential notifications we are hoping for:

For Funders

  • You have workers to approve on this issue.
  • Your bounty hunters haven't responded on this issue in a few days.
  • Remove them if you haven't heard from them?
  • There is a submission against your bounty.
  • Your bounty hunter has stopped work
  • Your bounty is expiring soonYour bounty has crowdfunding added to it.

For Hunters

  • You haven't responded to this issue in x days.
  • This issue has been remarketed and has your skill sets. Are you interested?
  • You have been approved for a bounty
  • You have been declined for a bounty
  • You have been removed from a bounty due to no responseYou have received a tip.
  • Your submission has been approved
  • Your submission has been declined.
  • Funding has increased on a bounty that you’re working on.

Additional Information

Please review with a core team member @PixelantDesign @willsputra @owocki

46431461-7656b200-c77e-11e8-86f2-18bd85c90af6

46431484-879fbe80-c77e-11e8-8431-36c611c4bde5

46483722-e15dc280-c82a-11e8-9744-7bae662136ad

46487325-4f59b800-c832-11e8-9769-70a1c70de009

46487326-4f59b800-c832-11e8-8397-b9547b1a7e76

Technical Approach

This should just be a new app named 'inbox' with one model Notification that has the following fields

pk
created_on
to_user_id
from_user_id
CTA_URL
CTA_Text
message_html
is_read (bool)
we will likely also want an easy helper function that can be used to create new Notifications

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.6 ETH (136.33 USD @ $227.22/ETH) attached to it as part of the Gitcoin fund__.__

@willsputra
Copy link
Contributor

@PixelantDesign
Copy link
Contributor Author

PixelantDesign commented Oct 10, 2018

Thanks @willsputra!

@Anish-Agnihotri to answer your question, this is a front-end ticket....please stub out dummy data as a placeholder to where we'd link up the BE dynamic template vars.
cc: @mbeacom

@usmanmuhd thanks for your interest! I have another ticket for you if you're interested!

@usmanmuhd
Copy link
Contributor

@PixelantDesign Sure!

@gitcoinbot
Copy link
Member

💰 A crowdfund contribution worth 125.00000 DAI (125.0 USD @ $1.0/DAI) has been attached to this funded issue from @vs77bb.💰

Want to chip in also? Add your own contribution here.

@gitcoinbot

This comment has been minimized.

3 similar comments
@gitcoinbot
Copy link
Member

@Anish-Agnihotri Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

@Anish-Agnihotri Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

@Anish-Agnihotri Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@Anish-Agnihotri
Copy link
Contributor

Anish-Agnihotri commented Oct 18, 2018

Seems like @gitcoinbot is really set on nagging me about this, haha.

I'll be pushing out a WIP PR this weekend. Been down with a fever for the past two days and am in bed, so programming has come down to snail speed. I'll get this knocked out though :).

@willsputra
Copy link
Contributor

How's it going @Anish-Agnihotri ? 🙂

@gitcoinbot

This comment has been minimized.

1 similar comment
@gitcoinbot
Copy link
Member

@Anish-Agnihotri Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@willsputra
Copy link
Contributor

Hey @Anish-Agnihotri , are you still working on this?

@Anish-Agnihotri
Copy link
Contributor

@willsputra Hey, apologies for going completely MIA on this issue. Certainly not good at all. It's 11/01. Give me till 11/03 and I'll get this knocked out and pushed on it's way.

Thanks again.

@Anish-Agnihotri
Copy link
Contributor

Status update:

I've gotten the modal working and everything is up and live. Figuring out notification integration and how to persistently populate the status bar dropout with content.

@willsputra
Copy link
Contributor

@Anish-Agnihotri thanks for the update! let us know if you have any questions :)

@owocki
Copy link
Contributor

owocki commented Nov 7, 2018

i'm very excited about this... @Anish-Agnihotri let us know what you need from us!

@Anish-Agnihotri
Copy link
Contributor

For sure :). My apologies for continued delay due to Diwali today. I'm attempting to pull notifications now and seeing how it is done in the back-end for the New Bounty emails for some reference.

Looking to get a WIP PR, and this knocked out asap.

@owocki
Copy link
Contributor

owocki commented Nov 12, 2018

@Anish-Agnihotri how goez it

@gitcoinbot

This comment has been minimized.

1 similar comment
@gitcoinbot
Copy link
Member

@Anish-Agnihotri Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot

This comment has been minimized.

@gitcoinbot
Copy link
Member

gitcoinbot commented Dec 4, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 years, 1 month ago.
Please review their action plans below:

1) usmanmuhd has been approved to start work.

I will create the backend as discussed with @octavioamu

Learn more on the Gitcoin Issue Details page.

@willsputra
Copy link
Contributor

@octavioamu @usmanmuhd notifications examples based on the list

For Hunters
screenshot 2018-12-05 01 22 32

For Funders
screenshot 2018-12-05 00 46 28

@PixelantDesign
Copy link
Contributor Author

@usmanmuhd looking forward to seeing a pr!

@thelostone-mc
Copy link
Member

Closing this out as we've got the base PR in

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.6 ETH (74.54 USD @ $124.24/ETH) has been submitted by:

  1. @usmanmuhd

@PixelantDesign please take a look at the submitted work:


@gitcoinbot
Copy link
Member

Helpotron ⚡️ A *Helpotron* Kudos has been sent to @usmanmuhd for this issue from @PixelantDesign. ⚡️

The sender had the following public comments:

Thanks for helping us out on notifications! Great work!

Nice work @usmanmuhd!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.6 ETH (71.69 USD @ $119.48/ETH) (plus a crowdfund of 0.4 ETH worth 47.7918933 USD) attached to this issue has been approved & issued to @usmanmuhd.

Thanks to @Anish-Agnihotri, @vs77bb for their crowdfunded contributions to this bounty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants