Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Changes to backend for notifications #3083

Merged
merged 5 commits into from
Dec 6, 2018

Conversation

usmanmuhd
Copy link
Contributor

@usmanmuhd usmanmuhd commented Dec 5, 2018

Backend for #2967
Refs: #2404

app/inbox/views.py Outdated Show resolved Hide resolved
app/inbox/views.py Outdated Show resolved Hide resolved
@usmanmuhd usmanmuhd changed the title [WIP] Changes to backend [WIP] Changes to backend for notifications Dec 5, 2018
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #3083 into new-notifications will decrease coverage by 12.94%.
The diff coverage is 25%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           new-notifications    #3083       +/-   ##
======================================================
- Coverage              29.86%   16.92%   -12.95%     
======================================================
  Files                    184      176        -8     
  Lines                  13754    13701       -53     
  Branches                1839     1836        -3     
======================================================
- Hits                    4108     2319     -1789     
- Misses                  9508    11374     +1866     
+ Partials                 138        8      -130
Impacted Files Coverage Δ
app/inbox/views.py 0% <0%> (-33.34%) ⬇️
app/inbox/models.py 92.85% <50%> (+0.54%) ⬆️
app/kudos/forms.py 0% <0%> (-100%) ⬇️
app/external_bounties/router.py 0% <0%> (-100%) ⬇️
app/avatar/urls.py 0% <0%> (-100%) ⬇️
app/external_bounties/forms.py 0% <0%> (-100%) ⬇️
app/app/urls.py 0% <0%> (-87.5%) ⬇️
app/dashboard/ios.py 0% <0%> (-77.78%) ⬇️
app/app/middleware.py 0% <0%> (-71.43%) ⬇️
app/app/context.py 0% <0%> (-70.38%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e6aa8f...fe6f274. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #3083 into new-notifications will decrease coverage by 0.05%.
The diff coverage is 12.5%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           new-notifications    #3083      +/-   ##
=====================================================
- Coverage              29.86%   29.81%   -0.06%     
=====================================================
  Files                    184      184              
  Lines                  13754    13761       +7     
  Branches                1839     1841       +2     
=====================================================
- Hits                    4108     4103       -5     
- Misses                  9508     9520      +12     
  Partials                 138      138
Impacted Files Coverage Δ
app/inbox/models.py 92.85% <50%> (+0.54%) ⬆️
app/inbox/views.py 25% <7.14%> (-8.34%) ⬇️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4972d7...d0b3330. Read the comment docs.

@usmanmuhd usmanmuhd force-pushed the notifs-backend branch 3 times, most recently from 03eaa77 to 979d1e4 Compare December 6, 2018 13:34
app/inbox/views.py Outdated Show resolved Hide resolved
app/inbox/views.py Outdated Show resolved Hide resolved
app/inbox/views.py Outdated Show resolved Hide resolved
app/inbox/views.py Outdated Show resolved Hide resolved
app/inbox/views.py Outdated Show resolved Hide resolved
app/inbox/views.py Outdated Show resolved Hide resolved
app/inbox/views.py Outdated Show resolved Hide resolved
@octavioamu octavioamu merged commit 710efeb into gitcoinco:new-notifications Dec 6, 2018
@usmanmuhd usmanmuhd deleted the notifs-backend branch December 6, 2018 14:24
@octavioamu octavioamu mentioned this pull request Dec 17, 2018
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants