code: Notifications #3221
code: Notifications #3221
Conversation
[WIP] Changes to backend for notifications
|
test notes:
|
| @@ -69,12 +77,20 @@ h4, | |||
| position: fixed; | |||
| top: 0; | |||
| left: 0; | |||
| /* right: 0; */ | |||
| let numPages = ''; | ||
| let numNotifications = ''; | ||
|
|
||
| Vue.mixin({ |
There was a problem hiding this comment.
excited to learn more about Vue -- itd becool to have a brownbag from you hearing how we can leverage Vue more for our codebase!
cc @SaptakS
There was a problem hiding this comment.
I believe that explorer and bounty details are great candidates to be in Vue, will facilitate a lot the states changes from the json request.
| ('new_milestone', 'New Milestone'), | ||
| ('update_milestone', 'Updated Milestone'), | ||
| ('new_kudos', 'New Kudos'), | ||
| ) |
There was a problem hiding this comment.
@usmanmuhd can you confirm that all of these notification types have been integrated?
There was a problem hiding this comment.
for example, i dont see killed_grant listed anywhere else in the codebase
| ('bounty_removed_by_funder', 'Removed from Bounty by Funder'), | ||
| ('new_crowdfund', 'New Crowdfund Contribution'), | ||
| ('new_grant', 'New Grant'), | ||
| ('update_grant', 'Updated Grant'), |
There was a problem hiding this comment.
update_grant not implemented either..
can you do a more exhaustive audit of these... we need to know which are implemented and which arent'
There was a problem hiding this comment.
Yes I said to @usmanmuhd to do the ones he could do, and we can see later the others. I mean is something we can be gradually implementing I believe.
[WIP] Added new notif generation
Description
Checklist
Affected core subsystem(s)
Refers/Fixes
Refs: #2404 #3083
Testing and Sign-off
Contributor
make testand everything passed!Reviewer
Funder