Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbox backend changes #3349

Merged
merged 5 commits into from
Jan 9, 2019

Conversation

usmanmuhd
Copy link
Contributor

@usmanmuhd usmanmuhd commented Dec 29, 2018

Refs: #3221 #2404

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #3349 into vue-notifications will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           vue-notifications    #3349      +/-   ##
=====================================================
+ Coverage              30.08%   30.09%   +<.01%     
=====================================================
  Files                    199      199              
  Lines                  14821    14823       +2     
  Branches                1934     1935       +1     
=====================================================
+ Hits                    4459     4461       +2     
  Misses                 10224    10224              
  Partials                 138      138
Impacted Files Coverage Δ
app/inbox/models.py 93.33% <ø> (ø) ⬆️
app/inbox/admin.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8cbfa5...0f970a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #3349 into vue-notifications will decrease coverage by 0.02%.
The diff coverage is 32.55%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           vue-notifications    #3349      +/-   ##
=====================================================
- Coverage              30.07%   30.05%   -0.03%     
=====================================================
  Files                    190      191       +1     
  Lines                  14562    14599      +37     
  Branches                1915     1924       +9     
=====================================================
+ Hits                    4380     4388       +8     
- Misses                 10043    10063      +20     
- Partials                 139      148       +9
Impacted Files Coverage Δ
app/inbox/models.py 93.33% <ø> (ø) ⬆️
app/dashboard/tip_views.py 18.91% <ø> (-0.66%) ⬇️
app/inbox/admin.py 100% <100%> (ø) ⬆️
app/inbox/apps.py 100% <100%> (+100%) ⬆️
app/inbox/signals.py 21.62% <21.62%> (ø)
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6a432...00658db. Read the comment docs.

app/inbox/apps.py Outdated Show resolved Hide resolved
app/inbox/signals.py Show resolved Hide resolved
app/inbox/signals.py Outdated Show resolved Hide resolved
app/inbox/signals.py Outdated Show resolved Hide resolved
app/inbox/apps.py Outdated Show resolved Hide resolved
@octavioamu
Copy link
Contributor

How is going @usmanmuhd ?

@usmanmuhd
Copy link
Contributor Author

Kind of badly stuck with figuring out how to generate notifications. Will try to get it in tomorrow.

@octavioamu octavioamu requested review from SaptakS and removed request for mbeacom January 7, 2019 16:17
app/inbox/signals.py Outdated Show resolved Hide resolved
@usmanmuhd usmanmuhd force-pushed the inbox-backend branch 6 times, most recently from 64b0af5 to 594618f Compare January 9, 2019 15:05
@octavioamu octavioamu merged commit fe78c7f into gitcoinco:vue-notifications Jan 9, 2019
@usmanmuhd usmanmuhd deleted the inbox-backend branch January 10, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants