Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Which Worker Was Approved #2819

Closed
1 task
PixelantDesign opened this issue Nov 14, 2018 · 22 comments
Closed
1 task

Display Which Worker Was Approved #2819

PixelantDesign opened this issue Nov 14, 2018 · 22 comments
Labels
Gitcoin Issue Detail Gitcoin Issue Detail good first issue This a good first issue for a community newcomer.

Comments

@PixelantDesign
Copy link
Contributor

User Story

As a contributor or funder looking at the activity list, it's hard to tell who has actually been approved for work.

Why Is this Needed

Summary: It's unclear right now

Description

Type: Enhancement

Current Behavior

Does not say who has been approved

Expected Behavior

It should say who has been approved

Definition of Done

  • It clearly states inline which worker has been approved.

Additional Information

In this scenario it should say: Worker Approved Evgeniuz

screen shot 2018-11-14 at 10 34 47 am

@PixelantDesign PixelantDesign added will tip for turnaround good first issue This a good first issue for a community newcomer. Gitcoin Issue Detail Gitcoin Issue Detail labels Nov 14, 2018
@usmanmuhd
Copy link
Contributor

Can I take this up?

@owocki
Copy link
Contributor

owocki commented Nov 14, 2018

  1. link to bounty pls?
  2. if you scroll up there is a 'work started' section that will list evgenius in it.

@PixelantDesign PixelantDesign changed the title Not Immediately Clear Which Worker Was Approved Display Which Worker Was Approved Nov 14, 2018
@kuhnchris
Copy link
Contributor

@owocki this is fine for the "first" worker applied, yes, but if you have dozens of applied workers who start/stop and then get approved then you kind of lose track who got approved when and where. Hence the "enhancement".

@usmanmuhd sure, if you find your way around, give it a try!

@pbteja1998
Copy link

Can I work on this issue ?

@kuhnchris
Copy link
Contributor

No idea, @usmanmuhd is this still open?

@usmanmuhd
Copy link
Contributor

Yeah sure, @pbteja1998 please take this up. I actually needed this for #2404 .

@pbteja1998
Copy link

I am trying to setup this repo locally. Everthing is fine except that I was unable to create funded issue. I am using Rinkeby test network. It has 18+ ether in it.
When I am trying to set the gas, it is showing unknown min confirmation.
Even if we ignore that time, when I clicked on fund issue, it is loading forever.
Can someone tell me what am I missing here? ( @usmanmuhd )

screenshot from 2019-01-06 17-05-04

@kuhnchris
Copy link
Contributor

please check the gas price DIRECTLY in metamask, for some reason my gas was reset to 1 GWEI, which was way too low. The unknown confirmation time is due to the missing gas cronjob that's running to determine the time (normal).
Can you check the logs (docker-compose logs --tail=100 web) ?

Thanks!

@pbteja1998
Copy link

How to start that cronjob?

@usmanmuhd
Copy link
Contributor

I don't think you need to start the cronjob. You can just increase the gas from within metamask payment.

@pbteja1998
Copy link

The thing is it is not asking for payment in metamask. when I click on Fund Issue it is just loading. No prompt for payment in metamask !

@usmanmuhd
Copy link
Contributor

Have you connected Gitcoin to metamask?

@pbteja1998
Copy link

yes

@pbteja1998
Copy link

I will try to rebuild again. Will see if it works.

@pbteja1998
Copy link

Is there anything else that I can do?

@pbteja1998
Copy link

  • Cloned the repo
  • cp app/app/local.env app/app/.env
    • BASE_URL=http://localhost:8000/
    • GITHUB_CLIENT_ID=xxxx
    • GITHUB_CLIENT_SECRET=xxxx
    • GITHUB_APP_NAME=xxxx
  • sudo docker-compose up --build

These are the steps that I followed for rebuilding. Still no luck !

@usmanmuhd
Copy link
Contributor

DM on slack, we can try figuring out.

@thelostone-mc
Copy link
Member

@usmanmuhd / @pbteja1998 lemme know if this works out. Else rope me into the conversation as well

@pbteja1998
Copy link

It is still unsolved

@kuhnchris
Copy link
Contributor

How about the environment?
Linux? Mac? Windows?
What Browser?
Old Metamask? Incognito Mode?
Some more infos then we can help, else pm me on Slack/Discord

@thelostone-mc
Copy link
Member

thelostone-mc commented Jan 6, 2019

@pbteja1998 mind heading over to our community channel and dropping a ping with
me @kuhnchris and @usmanmuhd ?

@octavioamu
Copy link
Contributor

Just a head up with this tasks I was discussing with @usmanmuhd and there are 2 ways at least to solve this issue, one is front end just using the data inside json metadata with worker_handle but he bring me the idea of change the model and I believe is the right way to go, because we actually have the other actions related to the worker not the owner, example
this is from activity related to this bounty https://gitcoin.co/issue/MyBitFoundation/MyBit.website/29/1953

image
As we see all the actions, removed, applied, stopped work are related to the worker (that is right) so I believe keeping the model with the owner name Approved doesn't make sense in the bounty or in the gitcoin.co/activity
So I believe we should change the field from the model to be filled with the worker and not the owner and that will be reflected in both places we need it.
@thelostone-mc any idea if this could break something in some place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Issue Detail Gitcoin Issue Detail good first issue This a good first issue for a community newcomer.
Projects
None yet
Development

No branches or pull requests

7 participants