Fix emoji flags detection #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrmannplatz
approved these changes
May 3, 2017
bennycode
approved these changes
May 3, 2017
lipis
reviewed
May 3, 2017
| @@ -32,6 +32,7 @@ describe 'z.util.emoji', -> | |||
| expect(z.util.emoji.includes_only_emojies('☕')).toBeTruthy() | |||
| expect(z.util.emoji.includes_only_emojies('⛄')).toBeTruthy() | |||
| expect(z.util.emoji.includes_only_emojies('⚽')).toBeTruthy() | |||
| expect(z.util.emoji.includes_only_emojies('🇩🇰')).toBeTruthy() | |||
lipis
approved these changes
May 3, 2017
lipis
added a commit
that referenced
this pull request
May 3, 2017
* 'eslint' of github.com:wireapp/wire-webapp: Updated translations (#1168) Skipping HTML comments (#1159) ES6: migrated "user" (#1138) Fix linting Return Object in ClientMapper.update_client() (#1158) chore(package): update eslint-plugin-jsdoc to version 3.0.2 (#1164) dont display blocked top people (#1163) Per-user count-based alphabetic emoji ordering (#1126) Fix removeEventListener on mouse click, fix emoji popup reappearing after a typo (#1133) Fix emoji flags detection (#1162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you send a message containing only emoji, it will have a larger font.
When you send a message containing only flag emoji (like 🇪🇺), it will not be recognized as emoji-only and thus will have a regular smaller font.
It is just a matter of adding extra range defining which symbols compose flags emojis (and in fact they consist of regional indicator symbol letters)