Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping HTML comments #1159

Merged
merged 3 commits into from
May 3, 2017
Merged

Skipping HTML comments #1159

merged 3 commits into from
May 3, 2017

Conversation

bennycode
Copy link
Contributor

I realized that we process src attributes from HTML comments within our *.htm files.

Example:

vendor.htm

<script src="/ext/js/cryptojs/md5.js"></script>
<script src="/ext/js/cryptojs/sha256.js"></script>
<!--<script src="/ext/js/linkifyjs/linkify.min.js"></script>-->
<!--<script src="/ext/js/linkifyjs/linkify-html.min.js"></script>-->

Before we would make use of ext/js/linkifyjs/linkify.min.js and ext/js/linkifyjs/linkify-html.min.js. I changed this behaviour so that there will be the following output:

Running "scripts" task
>> Processed files from 'app/page/template/_dist/app.htm'.
>> Processed files from 'app/page/template/_dist/auth.htm'.
>> Processed files from 'app/page/template/_dist/component.htm'.
Skipping file '/ext/js/linkifyjs/linkify.min.js' for minification.
Skipping file '/ext/js/linkifyjs/linkify-html.min.js' for minification.
>> Processed files from 'app/page/template/_dist/vendor.htm'.

@lipis
Copy link
Contributor

lipis commented May 2, 2017

but but but.. why do we have commented out code in a first place!?

@lipis
Copy link
Contributor

lipis commented May 2, 2017

Actually we don't 🍻 ✌️

@bennycode bennycode merged commit 138ea4a into dev May 3, 2017
@bennycode bennycode deleted the skip-html-comments branch May 3, 2017 09:49
lipis added a commit that referenced this pull request May 3, 2017
@lipis
Merge branch 'eslint' of github.com:wireapp/wire-webapp into eslint
a19fc8d 
* 'eslint' of github.com:wireapp/wire-webapp:
  Updated translations (#1168)
  Skipping HTML comments (#1159)
  ES6: migrated "user" (#1138)
  Fix linting
  Return Object in ClientMapper.update_client() (#1158)
  chore(package): update eslint-plugin-jsdoc to version 3.0.2 (#1164)
  dont display blocked top people (#1163)
  Per-user count-based alphabetic emoji ordering (#1126)
  Fix removeEventListener on mouse click, fix emoji popup reappearing after a typo (#1133)
  Fix emoji flags detection (#1162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregor gregor gregor approved these changes

@lipis lipis lipis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bennycode @lipis @gregor