Fix some recent bugs with emoji autocomplete #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
approved these changes
Apr 27, 2017
|
Thanks. Still getting used to the ES6 stuff |
bennycode
approved these changes
Apr 27, 2017
maximbaz
force-pushed
the
emoji-input-fix-bugs
branch
from
b9a1296 to
5ee857a
Compare
lipis
added a commit
that referenced
this pull request
May 3, 2017
* 'eslint' of github.com:wireapp/wire-webapp: Updated translations (#1168) Skipping HTML comments (#1159) ES6: migrated "user" (#1138) Fix linting Return Object in ClientMapper.update_client() (#1158) chore(package): update eslint-plugin-jsdoc to version 3.0.2 (#1164) dont display blocked top people (#1163) Per-user count-based alphabetic emoji ordering (#1126) Fix removeEventListener on mouse click, fix emoji popup reappearing after a typo (#1133) Fix emoji flags detection (#1162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove_emoji_listis executed multiple times on click, even if emoji popup is closed.This happens because
this.remove_emoji_list.bind(this)creates a new function every time, andwindow.removeEventListener('click', this.bound_remove_emoji_list)is trying to unassign a different function and silently fails to do so. The fix is to create a bound function and use it to assign and unassign a click-listener, so thataddEventListenerandremoveEventListenerare operating on exactly the same function.Previously if you entered a typo (like
winn), emoji popup was closed, but as soon as you removed the secondnit reappeared with suggestions likewink. Now it doesn't reappear, so you have to remove everything and start from scratch. This happenned because when nothing is matched, previously emoji popup was only closed, but then code was changed to actually remove the popup./cc @gregor