ES6: migrated "user" #1138
ES6: migrated "user" #1138
Conversation
|
|
||
| for (let i = 0; i < additional_numbers; i++) { | ||
| random_digits.push(z.util.get_random_int(1, 9)); | ||
| } |
There was a problem hiding this comment.
const random_digits = [...Array(additional_numbers).keys()].map(() => z.util.get_random_int(1, 9));There was a problem hiding this comment.
Also this 9 should be a const..
There was a problem hiding this comment.
Please read the paragraph "Extra code is not the enemy" from: https://dzone.com/articles/using-java-8-please-avoid-functional-vomit
There was a problem hiding this comment.
but less code sometimes it is :) rename i --==> index
| function generate_handle_variations(handle, number_of_variations = 5) { | ||
| return new Array(number_of_variations).map(function(value, i) { | ||
| i += 1; | ||
| return append_random_digits(handle.slice(0, MAX_HANDLE_LENGTH - i), i); |
app/script/user/UserRepository.js
Outdated
| } | ||
| } | ||
|
|
||
| get_connections(limit = 500, user_id, connection_ets = []) { |
There was a problem hiding this comment.
magic number.. maybe DEFAULT_CONNECTION_LIMIT
There was a problem hiding this comment.
Change single letter variables to something more meaningful.
Eventually we should introduce this rule as well.. http://eslint.org/docs/rules/id-length
|
@lipis: Let's make a deal... I will change |
|
OKi.. but I'll do it later tonight :) as it will be a fun thing to fix all of them! Either case... deal! |
app/script/user/UserError.js
Outdated
| break; | ||
| default: | ||
| this.message = 'Unknown UserError'; | ||
| break; |
| * @returns {Array<string>} Handle variations | ||
| */ | ||
| function generate_handle_variations(handle, number_of_variations = 5) { | ||
| return new Array(number_of_variations).map(function(value, index) { |
There was a problem hiding this comment.
This is not going to work. Map will skip but return undefined in an array: http://2ality.com/2013/11/initializing-arrays.html
return _.range(number_of_variations).map(function(value) {
return append_random_digits(handle.slice(0, MAX_HANDLE_LENGTH - value), value);
}
| function append_random_digits(handle, additional_numbers) { | ||
| const random_digits = []; | ||
|
|
||
| for (let index = 0; index < additional_numbers; index++) { |
There was a problem hiding this comment.
Simpler:
const random_digits = _.range(additional_numbers).map(() => z.util.get_random_int(1, 9));There was a problem hiding this comment.
we already discuss that one with @bennyn as I also suggested something similar.. and we agreed that it's not the most obvious thing :)
|
|
||
| if (data.service) { | ||
| user_et.is_bot = true; | ||
| user_et.provider_id = data.service.provider; |
There was a problem hiding this comment.
Good spot to use destructuring:
if (data.service) {
const {provider: provider_id, id: service_id} = data.service
user_et.is_bot = true;
user_et.provider_id = provider_id;
user_et.service_id = service_id;
There was a problem hiding this comment.
I prefer two lines over three lines:
user_et.provider_id = data.service.provider;
user_et.service_id = data.service.id;vs.
const {provider: provider_id, id: service_id} = data.service
user_et.provider_id = provider_id;
user_et.service_id = service_id;Especially because provider_id and service_id are not used anywhere else in this function.
app/script/user/UserRepository.js
Outdated
| this.connect_requests = ko.pureComputed(() => { | ||
| return this.users() | ||
| .filter((user_et) => user_et.connection().status() === z.user.ConnectionStatus.PENDING) | ||
| .map((user_et) => user_et); |
There was a problem hiding this comment.
What are you using map for here? Line seems obsolete.
There was a problem hiding this comment.
I am filtering undefined items with it.
app/script/user/UserService.js
Outdated
| initiate_password_reset(email, phone_number) { | ||
| return this.client.send_json({ | ||
| data: { | ||
| email, |
app/script/user/UserService.js
Outdated
| */ | ||
| update_own_user_profile(data) { | ||
| return this.client.send_json({ | ||
| data, |
app/script/user/UserService.js
Outdated
| change_own_email(email) { | ||
| return this.client.send_json({ | ||
| data: { | ||
| email, |
app/script/user/UserService.js
Outdated
| change_own_password(new_password, old_password) { | ||
| return this.client.send_json({ | ||
| data: { | ||
| new_password, |
There was a problem hiding this comment.
new_password: new_password,
old_password: old_password,
| */ | ||
| delete_self() { | ||
| return this.client.send_json({ | ||
| data: { |
There was a problem hiding this comment.
Has anyone ever checked why we send this data content? Seems like an obsolete placeholder that should be removed.
There was a problem hiding this comment.
I am just a messenger here... So should we change this code @herrmannplatz?
delete_self() {
return this.client.send_json({
data: {
todo: 'Change this to normal request!',
},
type: 'DELETE',
url: this.client.create_url(UserService.URL.SELF),
});
}
* 'eslint' of github.com:wireapp/wire-webapp: Updated translations (#1168) Skipping HTML comments (#1159) ES6: migrated "user" (#1138) Fix linting Return Object in ClientMapper.update_client() (#1158) chore(package): update eslint-plugin-jsdoc to version 3.0.2 (#1164) dont display blocked top people (#1163) Per-user count-based alphabetic emoji ordering (#1126) Fix removeEventListener on mouse click, fix emoji popup reappearing after a typo (#1133) Fix emoji flags detection (#1162)
Type of change
Screenshot