fix(html): ignore rewrite external urls

[bluwy]

Description

Fix #14770

Make sure relative urls that don't start with a . are not external urls by checking :. I think that should be good enough 🤔

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

Maybe we should use isExternalUrl and isDataUrl here? If checking for : is enough, we could replace these by checking but I'm not sure about that.
Related PR: #14744

[bluwy]

Oh I didn't realize #14744 was fixing a Vite beta regression (or it already exists before?)

I didn't use those as I figured a : is more performant and I can't think of cases where : exist and we want to transform it. I guess the other parts of the codebase is isExternalUrl and isDataUrl so it doesn't incorrectly match Windows paths, but in this HTML case we also wouldn't want to match Windows paths.

If you prefer the consistency, I don't mind changing this to isExternalUrl and isDataUrl though (and also the #). It looks like #14744 isn't completed yet.

[patak-dev]

Yes, for #14744, I think it is better to use the functions directly instead of extracting the excludeUrl util. I'll get to it if it doesn't progress.

About using isExternalUrl/isDataUrl, it seems to me there are other places that are the same as this one where it is being used. I'm ok if you'd like to merge this one with the perf optimization already (and maybe later we could review others). It would be good to have a comment explaining that : discards external and data URLs. I wonder why we are checking only for https:// in isExternal though, your will also hit other protocols like ipfs://, that we should also probably be ignoring as external, no?

[bluwy]

I can add the comment 👍 Yeah the external issue seems to be related to #13540. Quite a bit of refactors if we want to fix this up and definitely worth reviewing again.