Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: processNodeUrl for srcset #14870

Merged
merged 3 commits into from
Nov 6, 2023
Merged

fix: processNodeUrl for srcset #14870

merged 3 commits into from
Nov 6, 2023

Conversation

patak-dev
Copy link
Member

Closes #14744

Description

See newly added test, we were doing url tests on the srcset value:

  <img
    class="img-src-set-mixed"
    src="/icon.png"
    srcset="https://vitejs.dev/logo-with-shadow.png 1x, ./nested/asset.png 2x"
    alt=""
  />

It only worked so far because normally all the URLs in srcset will be of the same type (in src, or in public, or external)

The new test is failing during build, I added a condition and a TODO to fix that in another PR.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

stackblitz bot commented Nov 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Nov 3, 2023
sapphi-red
sapphi-red previously approved these changes Nov 4, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Does this fix #14744? It looks a bit different.

@patak-dev
Copy link
Member Author

patak-dev commented Nov 4, 2023

It should fix it after #14774 and this PR (for dev), we can ask for an issue with a proper reproduction if not.

@sapphi-red sapphi-red dismissed their stale review November 5, 2023 09:11

See blu's review

@patak-dev patak-dev enabled auto-merge (squash) November 6, 2023 10:31
@patak-dev patak-dev merged commit 0873bae into main Nov 6, 2023
15 checks passed
@patak-dev patak-dev deleted the fix/process-node-url branch November 6, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants