fix: external URLs normalized to absolute path #14744
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of incorrectly handling external URLs within the index.html file. When external URLs are included using the <script> tag, they get merged with the base path, resulting in malformations like /https:// (or prepended with whatever the BASE_URL is).
The changes introduced in this PR ensure that the strings are checked to determine if they are valid URLs before merging, preventing such issues.
Additional context
The problem arose when external script URLs were getting prefixed with the base path, which should not happen. This fix aims to streamline the handling of URLs and prevent potential errors caused by this incorrect merging.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).