Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix something in Chat and ChatService #403

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Fix something in Chat and ChatService #403

merged 2 commits into from
Nov 17, 2024

Conversation

fishshi
Copy link
Collaborator

@fishshi fishshi commented Nov 17, 2024

  1. filePaths may be undefined in ChatService, for example when you edit a message that has been sent.
  2. change the order of save and request in Chat to avoid that a long lasting generation causes the generation of save title timeout.

rjmacarthy
rjmacarthy approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@rjmacarthy rjmacarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this, will be released with all latest updates. Many thanks!

@rjmacarthy rjmacarthy merged commit 0445098 into twinnydotdev:development Nov 17, 2024
rjmacarthy added a commit that referenced this pull request Nov 18, 2024
@rjmacarthy @ZhongGuangshen @fishshi
development > main (#399)
e1c9696 
* zh-CN (#397)

* translate zh-HK (#396)

* zh-HK

* zh-HK reserve sapce in the last line for linting

* add onStart and controller to review-service (#401)

* fix that empty message following timeout message (#402)

* Fix something in Chat and ChatService (#403)

* Adjust the order of save and request in handleSubmitForm

* Fix issue when filePaths is undefined.

* add locale switcher

* 3.19.7

* lint

---------

Co-authored-by: Incarnation-of-Wasted-souls <[email protected]>
Co-authored-by: fishshi <[email protected]>
@fishshi fishshi deleted the fix/chat0 branch November 18, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmacarthy rjmacarthy rjmacarthy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishshi @rjmacarthy