Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the stop button not working during review #401

Merged

Conversation

fishshi
Copy link
Collaborator

@fishshi fishshi commented Nov 16, 2024

When using the review service, the stop button does not work beacuse of the missing onStart.

Copy link
Collaborator

@rjmacarthy rjmacarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rjmacarthy rjmacarthy merged commit db44646 into twinnydotdev:development Nov 16, 2024
rjmacarthy added a commit that referenced this pull request Nov 18, 2024
* zh-CN (#397)

* translate zh-HK (#396)

* zh-HK

* zh-HK reserve sapce in the last line for linting

* add onStart and controller to review-service (#401)

* fix that empty message following timeout message (#402)

* Fix something in Chat and ChatService (#403)

* Adjust the order of save and request in handleSubmitForm

* Fix issue when filePaths is undefined.

* add locale switcher

* 3.19.7

* lint

---------

Co-authored-by: Incarnation-of-Wasted-souls <[email protected]>
Co-authored-by: fishshi <[email protected]>
@fishshi fishshi deleted the fix/stop_when_reviewing branch November 18, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants