Fix that empty message following timeout message #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmacarthy
approved these changes
Nov 17, 2024
rjmacarthy
added a commit
that referenced
this pull request
Nov 18, 2024
* zh-CN (#397) * translate zh-HK (#396) * zh-HK * zh-HK reserve sapce in the last line for linting * add onStart and controller to review-service (#401) * fix that empty message following timeout message (#402) * Fix something in Chat and ChatService (#403) * Adjust the order of save and request in handleSubmitForm * Fix issue when filePaths is undefined. * add locale switcher * 3.19.7 * lint --------- Co-authored-by: Incarnation-of-Wasted-souls <[email protected]> Co-authored-by: fishshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original timeout handling, Twinny used controller.abort(), which threw an AbortError exception for the fetch operation, causing
onEnd?.()instreamResponseto be called.At the same time, set a longer time (1 min) for timeout.
try to fix #400