Fix something in Chat and ChatService (#403)

* Adjust the order of save and request in handleSubmitForm * Fix issue when filePaths is undefined.
twinnydotdev · Nov 17, 2024 · 0445098 · 0445098
1 parent c792f1e
commit 0445098
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/extension/chat-service.ts b/src/extension/chat-service.ts
@@ -530,7 +530,7 @@ export class ChatService extends Base {
     return combinedContext.trim() || null
   }
 
-  private async loadFileContents(files: FileItem[]): Promise<string> {
+  private async loadFileContents(files?: FileItem[]): Promise<string> {
     if (!files?.length) return ""
     let fileContents = ""
     for (const file of files) {
@@ -546,7 +546,7 @@ export class ChatService extends Base {
 
   public async streamChatCompletion(
     messages: Message[],
-    filePaths: FileItem[]
+    filePaths?: FileItem[]
   ) {
     this._completion = ""
     this.sendEditorLanguage()
@@ -577,7 +577,7 @@ export class ChatService extends Base {
       additionalContext += `Additional Context:\n${ragContext}\n\n`
     }
 
-    filePaths = filePaths.filter((filepath) =>
+    filePaths = filePaths?.filter((filepath) =>
       filepath.name !== "workspace" && filepath.name !== "problems"
     )
     const fileContents = await this.loadFileContents(filePaths)

diff --git a/src/webview/chat.tsx b/src/webview/chat.tsx
@@ -305,12 +305,13 @@ export const Chat = (props: ChatProps): JSX.Element => {
         meta: mentions,
       }
 
-      global.vscode.postMessage(clientMessage)
-
       saveLastConversation({
         ...conversation,
         messages: updatedMessages,
       })
+
+      global.vscode.postMessage(clientMessage)
+
       return updatedMessages
     })