change naming of defines to include namespace

[dirk-thomas]

The currently defined macros to log messages (e.g.

console_bridge/include/console_bridge/console.h

Line 68 in 7aebc33

#define logWarn(fmt, ...) console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_WARN, fmt, ##__VA_ARGS__)

) are much to generic and collide with existing code. The should be prefixed with the package name to make them unique.

Even if this is a significant API change this should be fixed. Likely bumping more then just the patch version number.

[scpeters]

So, for example, you would like the logWarn macro to change to something like CONSOLE_BRIDGE_logWarn?

[scpeters]

@dirk-thomas ping

[dirk-thomas]

Yes, prefixing all functions with console_bridge_ and macros with CONSOLE_BRIDGE_ would namespace those to prevent collisions.

[wjwwood]

What remains to be done here? It looks like @scpeters has at least added the new macros as an alternative?

[scpeters]

Yeah, the new macros have been added, and the old ones are deprecated but still present. I was waiting to close this until the next version is released with the old macros redacted.

[wjwwood]

Sounds good to me.

[mikaelarguedas]

@scpeters friendly 🔔 Is there still a plan to release a new version with the deprecated macros removed?

[scpeters]

should we call it a 1.0?

[mikaelarguedas]

Hmmm that's a good question, given the ros namespacing constraints I usually do only minor and patch releases even when breaking API. As this package is submitted upstream and not tied to a given distribution I think it would make sense to bump the major.
Maybe @tfoote or @dirk-thomas can give feedback on this as well

[dirk-thomas]

Following semver it should be at least 0.4 since it breaks API.

[scpeters]

It depends on your interpretation of semantic versioning. We are extra strict in gazebo to bump major version if API or ABI changes.

It's worth noting that the config version file uses COMPATIBILITY SameMajorVersion.

But I'll defer to you.

[wjwwood]

Also:

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

-- http://semver.org/#spec-item-4

[scpeters]

That's a fair point. I take it that most are in favor of 0.4? If so I'll make a PR that bumps the version and removes the deprecated macros.

[scpeters]

see #48