-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duplicate macros with namespace prefix #24
Conversation
The "deprecated" macros should actually result in a deprecation warning in order for users to notice that they should update their code using console bridge. |
The question will be how should this be rolled out:
|
deprecation warnings in b6d96f9 |
I vote for 2 |
I also bumped the minor (509ca97) since adding the deprecation warnings |
509ca97
to
1b687b7
Compare
Add duplicate macros to console.h with `CONSOLE_BRIDGE_` prepended. First step in fixing ros#18.
I'd like to make a new release. I'll merge this within the next few hours if I don't hear any other comments. |
Add duplicate macros with namespace prefix
Add duplicate macros to console.h with
CONSOLE_BRIDGE_
prepended.First step in fixing #18. These new macros can be released in a patch release, then we will remove the old macros when bumping the major or minor.
@dirk-thomas