Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate macros with namespace prefix #24

Merged
merged 3 commits into from
Jan 15, 2016

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Dec 9, 2015

Add duplicate macros to console.h with CONSOLE_BRIDGE_ prepended.

First step in fixing #18. These new macros can be released in a patch release, then we will remove the old macros when bumping the major or minor.

@dirk-thomas

@dirk-thomas
Copy link
Member

The "deprecated" macros should actually result in a deprecation warning in order for users to notice that they should update their code using console bridge.

@dirk-thomas
Copy link
Member

The question will be how should this be rolled out:

  1. A patch release now with the namespaced API added, a major release with the old API being released in Xenial.
  2. Add the new API in Xenial together with deprecating the old API, remove the old API in Ubuntu Z / ROS L.

@scpeters
Copy link
Contributor Author

scpeters commented Dec 9, 2015

deprecation warnings in b6d96f9

@scpeters
Copy link
Contributor Author

scpeters commented Dec 9, 2015

I vote for 2

@scpeters
Copy link
Contributor Author

scpeters commented Dec 9, 2015

I also bumped the minor (509ca97) since adding the deprecation warnings

@scpeters
Copy link
Contributor Author

scpeters commented Dec 9, 2015

@j-rivero how possible is it to patch the current version of libconsole-bridge in trusty with 87c6893?

@j-rivero
Copy link
Contributor

@j-rivero how possible is it to patch the current version of libconsole-bridge in trusty with 87c6893?

We would need to demostrate that if fixes a critical bug, which I believe that would be quite a hard work this time.

Add duplicate macros to console.h with
`CONSOLE_BRIDGE_` prepended.
First step in fixing ros#18.
@scpeters
Copy link
Contributor Author

I'd like to make a new release. I'll merge this within the next few hours if I don't hear any other comments.

scpeters added a commit that referenced this pull request Jan 15, 2016
Add duplicate macros with namespace prefix
@scpeters scpeters merged commit bbcc914 into ros:master Jan 15, 2016
@scpeters scpeters deleted the macro_namespace branch January 15, 2016 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants