Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libconsole-bridge-dev to ci environment #159

Closed
wants to merge 1 commit into from

Conversation

tfoote
Copy link
Contributor

@tfoote tfoote commented Dec 6, 2015

This adds libconsole-bridge into the linux docker image.

We need to add it to the osx and windows builds too.

For OSX it's available via brew. I don't know how to resolve it for Windows besides saying to install it from source.

Connects to #153

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Dec 6, 2015
@tfoote tfoote self-assigned this Dec 6, 2015
@dirk-thomas
Copy link
Member

Is this necessary for tf? For that it would be fine for now but for ROS 2 in general I am not sure if that is the right foundation.

@tfoote
Copy link
Contributor Author

tfoote commented Dec 6, 2015

tf needs some logging library.

We haven't addressed logging and we should probably talk about this in the next meeting. But this has been the recommended way to do ROS independent logging that can be integrated well with ROS console logging. I think it would be a mistake not to have it be a first class citizen for ROS2.

@wjwwood
Copy link
Member

wjwwood commented Dec 6, 2015

@tfoote this will not work, console_bridge needs changes to be used by ROS2, which I made in the ros2 branch on the console_bridge repo: https://github.com/ros/console_bridge/tree/ros2

And I proposed in this pr for class_loader: #133

@tfoote
Copy link
Contributor Author

tfoote commented Dec 7, 2015

I can bring in console_bridge to the build tree from #133 is that what we want to do? Do we expect this to go upstream? If so we should be pushing on that now.

@dirk-thomas
Copy link
Member

Console bridge does currently not use any namespace which make it collide with other code. This was filled quite some time ago but couldn't be addressed in a non-breaking way (ros/console_bridge#18). I think we shouldn't continue to use it as-is in ROS 2 but address the problem.

@wjwwood
Copy link
Member

wjwwood commented Dec 7, 2015

I think we should take the changes I made and make the ones @dirk-thomas pointed out and push for them upstream, but realistically that won't happen for a while. This isn't on my critical path though, so I haven't been pushing on #133.

@tfoote
Copy link
Contributor Author

tfoote commented Dec 7, 2015

I've pulled @wjwwood 's version from #133 into #160 and am rerunning tests.

@tfoote
Copy link
Contributor Author

tfoote commented Dec 8, 2015

console bridge is in the workspace in #160

@tfoote tfoote closed this Dec 8, 2015
@tfoote tfoote removed the in progress Actively being worked on (Kanban column) label Dec 8, 2015
@wjwwood wjwwood deleted the ci_scripts_add_console_bridge branch June 23, 2016 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants