-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libconsole-bridge-dev to ci environment #159
Conversation
Is this necessary for tf? For that it would be fine for now but for ROS 2 in general I am not sure if that is the right foundation. |
tf needs some logging library. We haven't addressed logging and we should probably talk about this in the next meeting. But this has been the recommended way to do ROS independent logging that can be integrated well with ROS console logging. I think it would be a mistake not to have it be a first class citizen for ROS2. |
@tfoote this will not work, And I proposed in this pr for |
I can bring in console_bridge to the build tree from #133 is that what we want to do? Do we expect this to go upstream? If so we should be pushing on that now. |
Console bridge does currently not use any namespace which make it collide with other code. This was filled quite some time ago but couldn't be addressed in a non-breaking way (ros/console_bridge#18). I think we shouldn't continue to use it as-is in ROS 2 but address the problem. |
I think we should take the changes I made and make the ones @dirk-thomas pointed out and push for them upstream, but realistically that won't happen for a while. This isn't on my critical path though, so I haven't been pushing on #133. |
console bridge is in the workspace in #160 |
This adds libconsole-bridge into the linux docker image.
We need to add it to the osx and windows builds too.
For OSX it's available via brew. I don't know how to resolve it for Windows besides saying to install it from source.
Connects to #153