Quesiton: Code fail to compile in ROS Melodic

[caguero]

Question: I failed to compile the code in master in an Ubuntu Bionic distribution with ROS Melodic because all calls to logWarn, logDebug failed. Here's an example:

In file included from /home/developer/jackal_ws/src/LMS1xx/include/LMS1xx/LMS1xx.h:27:0,
                 from /home/developer/jackal_ws/src/LMS1xx/src/LMS1xx.cpp:36:
/home/developer/jackal_ws/src/LMS1xx/include/LMS1xx/lms_buffer.h: In member function 'void LMSBuffer::readFrom(int)':
/home/developer/jackal_ws/src/LMS1xx/include/LMS1xx/lms_buffer.h:54:7: error: 'logWarn' was not declared in this scope
       logWarn("Buffer read() returned error.");

I have a patch that fixes the issue (essentially adding the CONSOLE_BRIDGE_ prefix to all of them. Do you have any plans for supporting ROS Melodic? Should I just submit a pull request against master? Are you considering a separate release branch for Melodic maybe?

[scpeters]

This is related to ros/console_bridge#18; the logWarn and other macros were changed to have a prefix. The old macros were deprecated with new macros added in console_bridge 0.3 (xenial/kinetic), and the old macros were removed in 0.4 (bionic/melodic).

So the patch that @caguero is talking about will fix compiler warnings on (xenial/kinetic), fix compilation on (bionic/melodic), and break compilation on (trusty/indigo).

• https://github.com/ros/console_bridge/releases
• https://packages.ubuntu.com/trusty/libconsole-bridge-dev
• https://packages.ubuntu.com/xenial/libconsole-bridge-dev
• https://packages.ubuntu.com/bionic/libconsole-bridge-dev

If you want to keep supporting trusty/indigo, you might want to consider making a new branch.

[FahadRazaKhan]

Faced the same Error, and fixed it as @caguero said. BTW is there any easy way to it instead of adding prefix in the code?
Thank you.

[tonybaltovski]

This has been fixed.