feat: overwrite min-gas-prices to combat empty blocks #8131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
added
V:state/compatible/backport
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
* fix config and app toml overwrites * changelog * more fixes * changelog name * push * push * clean up * reduce diff * comments * print propper * lint * only change the respective lines, rather than the entire file * reduce diff * abstraction * even more abstraction * add in line comments * update config * in line comments * fix overwrite bug * reduce diff * overwrite min gas prices * changelog * changelog (cherry picked from commit a9552b3)
czarcas7ic
added a commit
that referenced
this pull request
Apr 24, 2024
* fix config and app toml overwrites * changelog * more fixes * changelog name * push * push * clean up * reduce diff * comments * print propper * lint * only change the respective lines, rather than the entire file * reduce diff * abstraction * even more abstraction * add in line comments * update config * in line comments * fix overwrite bug * reduce diff * overwrite min gas prices * changelog * changelog (cherry picked from commit a9552b3) Co-authored-by: Adam Tucker <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
With EIP 1559 implemented on Osmosis, the min gas fee is calculated on the fly based on block space used. The min-gas-price set in the app.toml, however, overwrites whatever is calculated. This results in empty blocks being proposed by validators with this value set.
Implements https://forum.osmosis.zone/t/temp-check-default-validator-configuration-of-0-minimum-gas-price/2701
Testing and Verifying
I set this value to 0.01uosmo, ran
osmosisd start, then saw the value changed to 0uosmo in the app.toml