Skip to content

Commit

Permalink
feat: overwrite min-gas-prices to combat empty blocks (#8131) (#8133)
Browse files Browse the repository at this point in the history
* fix config and app toml overwrites

* changelog

* more fixes

* changelog name

* push

* push

* clean up

* reduce diff

* comments

* print propper

* lint

* only change the respective lines, rather than the entire file

* reduce diff

* abstraction

* even more abstraction

* add in line comments

* update config

* in line comments

* fix overwrite bug

* reduce diff

* overwrite min gas prices

* changelog

* changelog

(cherry picked from commit a9552b3)

Co-authored-by: Adam Tucker <[email protected]>
  • Loading branch information
mergify[bot] and czarcas7ic authored Apr 24, 2024
1 parent 86e33a2 commit ed42ce1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### State Compatible

## v24.0.2

* [#8006](https://github.com/osmosis-labs/osmosis/pull/8006), [#8014](https://github.com/osmosis-labs/osmosis/pull/8014) Speedup many BigDec operations
* [#8030](https://github.com/osmosis-labs/osmosis/pull/8030) Delete legacy behavior where lockups could not unbond at very small block heights on a testnet
* [#8118](https://github.com/osmosis-labs/osmosis/pull/8118) Config.toml and app.toml overwrite improvements
* [#8131](https://github.com/osmosis-labs/osmosis/pull/8131) Overwrite min-gas-prices to 0uosmo (defaulting to the EIP 1559 calculated value) to combat empty blocks

## v24.0.1

Expand Down
8 changes: 7 additions & 1 deletion cmd/osmosisd/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ type SectionKeyValue struct {

var (
recommendedAppTomlValues = []SectionKeyValue{
{
Section: "",
Key: "minimum-gas-prices",
Value: "0uosmo",
},
{
Section: "osmosis-mempool",
Key: "arbitrage-min-gas-fee",
Expand All @@ -113,7 +118,8 @@ var (
Section: "osmosis-mempool",
Key: "max-gas-wanted-per-tx",
Value: "60000000",
}}
},
}

recommendedConfigTomlValues = []SectionKeyValue{
{
Expand Down

0 comments on commit ed42ce1

Please sign in to comment.