Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overwrite min-gas-prices to combat empty blocks (backport #8131) #8133

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 24, 2024

Closes: #XXX

What is the purpose of the change

With EIP 1559 implemented on Osmosis, the min gas fee is calculated on the fly based on block space used. The min-gas-price set in the app.toml, however, overwrites whatever is calculated. This results in empty blocks being proposed by validators with this value set.

Implements https://forum.osmosis.zone/t/temp-check-default-validator-configuration-of-0-minimum-gas-price/2701

Testing and Verifying

I set this value to 0.01uosmo, ran osmosisd start, then saw the value changed to 0uosmo in the app.toml


This is an automatic backport of pull request #8131 done by Mergify.

* fix config and app toml overwrites

* changelog

* more fixes

* changelog name

* push

* push

* clean up

* reduce diff

* comments

* print propper

* lint

* only change the respective lines, rather than the entire file

* reduce diff

* abstraction

* even more abstraction

* add in line comments

* update config

* in line comments

* fix overwrite bug

* reduce diff

* overwrite min gas prices

* changelog

* changelog

(cherry picked from commit a9552b3)
@czarcas7ic czarcas7ic merged commit ed42ce1 into v24.x Apr 24, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the mergify/bp/v24.x/pr-8131 branch April 24, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant