Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overwrite min-gas-prices to combat empty blocks #8131

Merged
merged 24 commits into from
Apr 24, 2024
Merged

feat: overwrite min-gas-prices to combat empty blocks #8131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3f29363
fix config and app toml overwrites
czarcas7ic Apr 21, 2024
ccc5675
changelog
czarcas7ic Apr 21, 2024
d41515d
more fixes
czarcas7ic Apr 21, 2024
4df772e
changelog name
czarcas7ic Apr 21, 2024
8b9ed67
push
czarcas7ic Apr 22, 2024
0af5c57
push
czarcas7ic Apr 22, 2024
ef1d831
clean up
czarcas7ic Apr 22, 2024
050477b
reduce diff
czarcas7ic Apr 22, 2024
76de652
comments
czarcas7ic Apr 22, 2024
4e0b604
print propper
czarcas7ic Apr 22, 2024
2e6fd7b
lint
czarcas7ic Apr 22, 2024
c79bba5
only change the respective lines, rather than the entire file
czarcas7ic Apr 23, 2024
cdc9230
reduce diff
czarcas7ic Apr 23, 2024
3d7bcdb
abstraction
czarcas7ic Apr 23, 2024
84264af
even more abstraction
czarcas7ic Apr 23, 2024
a14c567
add in line comments
czarcas7ic Apr 23, 2024
05bca21
update config
czarcas7ic Apr 23, 2024
2b6a020
in line comments
czarcas7ic Apr 23, 2024
8bd69b6
fix overwrite bug
czarcas7ic Apr 23, 2024
ae196d5
reduce diff
czarcas7ic Apr 23, 2024
fcda56e
overwrite min gas prices
czarcas7ic Apr 23, 2024
c4a3849
changelog
czarcas7ic Apr 23, 2024
2237255
changelog
czarcas7ic Apr 23, 2024
b05ee50
Merge branch 'main' into adam/min-gas-price-overwrite
czarcas7ic Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### State Compatible

## v24.0.2

* [#8006](https://github.com/osmosis-labs/osmosis/pull/8006), [#8014](https://github.com/osmosis-labs/osmosis/pull/8014) Speedup many BigDec operations
* [#8030](https://github.com/osmosis-labs/osmosis/pull/8030) Delete legacy behavior where lockups could not unbond at very small block heights on a testnet
* [#8118](https://github.com/osmosis-labs/osmosis/pull/8118) Config.toml and app.toml overwrite improvements
* [#8131](https://github.com/osmosis-labs/osmosis/pull/8131) Overwrite min-gas-prices to 0uosmo (defaulting to the EIP 1559 calculated value) to combat empty blocks

## v24.0.1

Expand Down
8 changes: 7 additions & 1 deletion cmd/osmosisd/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ type SectionKeyValue struct {

var (
recommendedAppTomlValues = []SectionKeyValue{
{
Section: "",
Key: "minimum-gas-prices",
Value: "0uosmo",
},
{
Section: "osmosis-mempool",
Key: "arbitrage-min-gas-fee",
Expand All @@ -113,7 +118,8 @@ var (
Section: "osmosis-mempool",
Key: "max-gas-wanted-per-tx",
Value: "60000000",
}}
},
}

recommendedConfigTomlValues = []SectionKeyValue{
{
Expand Down