fix: mixed lifeCyclesContent when empty lifecycles

[chilingling]

修复生命周期为空时，取当前页面schema生命周期值的 bug

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

打开页面设置，如果：

1. 当前设置页面与当前编辑页面（画布编辑的页面）不一致
2. 当前设置的页面生命周期为空

则当前设置的页面声明周期会取当前编辑页面生命周期的值

Issue Number: #806

What is the new behavior?

当前设置的页面声明周期不取当前编辑页面生命周期的值，保持为空

Does this PR introduce a breaking change?

• Yes
• No

Other information

[coderabbitai]

Walkthrough

The changes involve a modification to the state.bindLifeCycles property assignment within the watchEffect function of the LifeCycles.vue component. The new implementation simplifies the assignment by directly setting state.bindLifeCycles to props.bindLifeCycles, removing the previous fallback mechanism that retrieved life cycles from the canvas API. This results in a more straightforward code structure.

Changes

Files	Change Summary
packages/common/component/LifeCycles.vue	Simplified assignment of state.bindLifeCycles by removing fallback to canvas API.

Assessment against linked issues

Objective	Addressed	Explanation
Prevent code loss when switching between pages (806)	❌	The changes do not address the issue of code being overwritten.

Poem

In a code so bright, a rabbit hops,
Simplifying life cycles, no more drops.
From canvas to props, a clearer way,
Hooray for changes that brighten the day!
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

packages/common/component/LifeCycles.vue (1)

Line range hint 1-424: Consider broader implications and add comprehensive tests

The change to simplify lifecycle data assignment looks good and aligns with the PR objectives. However, consider the following points:

1. The PR description mentions fixing the issue "when the lifecycle is empty," but this change applies to all cases. Ensure that this broader change doesn't introduce unexpected behavior in non-empty lifecycle scenarios.

2. The removal of the canvas API fallback might affect other parts of the application that relied on this behavior. Verify that no other components or functions depended on the previous implementation.

To ensure the robustness of this change:

1. Add comprehensive unit tests covering various scenarios:

   • Empty lifecycle
   • Non-empty lifecycle
   • Switching between pages with different lifecycle configurations

2. Update the component's documentation to reflect the new behavior and any changes in expected props.

3. Consider adding a migration guide or update notes if this change might affect other developers using this component.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2ce7c4a and 56b4283.

Files selected for processing (1)

• packages/common/component/LifeCycles.vue (1 hunks)

Additional comments not posted (1)

packages/common/component/LifeCycles.vue (1)

132-132: LGTM! Simplified lifecycle data assignment.

This change simplifies the assignment of state.bindLifeCycles by directly using props.bindLifeCycles with a fallback to an empty object. This aligns with the PR objective of fixing issues related to incorrect retrieval of lifecycle values.

To ensure this change doesn't introduce any regressions:

1. Verify that props.bindLifeCycles is always up-to-date and correctly passed to this component.
2. Test scenarios where lifecycle data was previously fetched from the canvas API to ensure no critical information is lost.
3. Confirm that this change resolves the issue of onMounted code being overwritten when switching between pages (issue 🐛 [Bug]: onMounted代码被覆盖 #806).

Run the following script to check for any remaining references to getSchema().lifeCycles in the codebase:

If any results are found, review those occurrences to ensure consistency with this change.

Verification successful

Action Required: Correcting Search Command for Vue Files

The previous search command failed because 'vue' is not a recognized file type. Please run the following script to search for references to getSchema().lifeCycles in .vue and .js files:

---

No Remaining References to getSchema().lifeCycles Found

The search did not return any remaining references to getSchema().lifeCycles in .vue and .js files. This confirms that the lifecycle data assignment change is properly implemented without leaving any dependencies on the canvas API.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to getSchema().lifeCycles
rg --type vue --type js 'getSchema\(\).*lifeCycles'

Length of output: 81

---

Script:

#!/bin/bash
# Search for any remaining references to getSchema().lifeCycles in .vue and .js files
rg --glob '*.vue' --glob '*.js' 'getSchema\(\).*lifeCycles'

Length of output: 61