Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generate-vue):修复出码文件选择界面打包后样式丢失问题 #789

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

BWrong
Copy link
Contributor

@BWrong BWrong commented Sep 4, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced the build process by ensuring the CSS file is imported at the beginning of generated output files for improved styling.

Copy link
Contributor

coderabbitai bot commented Sep 4, 2024

Walkthrough

The update modifies the Rollup configuration in the vite.config.js file by adding an output property to the rollupOptions object. This new property includes a banner field, which specifies the string import "./style.css" to be included at the top of generated output files. This adjustment ensures that the specified CSS file is imported correctly in the output.

Changes

Files Change Summary
packages/toolbars/generate-vue/vite.config.js Added output property with banner field to rollupOptions, specifying import "./style.css" at the top of output files.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Vite
    participant Rollup

    User->>Vite: Initiates build process
    Vite->>Rollup: Configures Rollup options
    Rollup->>Rollup: Adds output banner
    Rollup-->>Vite: Generates output files
    Vite-->>User: Returns built application
Loading

Poem

🐰 In a world of code, so bright and new,
A banner was added, with style to pursue.
"Import this CSS!" it cheerfully sings,
Enhancing the output, oh what joy it brings!
With hops and with skips, we celebrate this feat,
A rabbit's delight in a build so neat! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c35c34e and eb364db.

Files selected for processing (1)
  • packages/toolbars/generate-vue/vite.config.js (1 hunks)
Additional comments not posted (1)
packages/toolbars/generate-vue/vite.config.js (1)

31-33: LGTM!

The code changes are approved.

Copy link
Collaborator

@hexqi hexqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hexqi hexqi merged commit 603be3b into opentiny:develop Sep 11, 2024
1 check passed
chilingling added a commit that referenced this pull request Sep 24, 2024
* fix(mockServer): mockServer page preview can't render element-plus element (#503)

* fix(style): fix render error caused by inline style breaks (#526)

* fix(metaComp): fix bug where metaHtmlText could set value to incorret schema children (#473)

* fix(vue-generator): fix globalstate codegen error (#547)

* fix(material): add componentsMap to app Schema after material build (#527)

* fix: slot params missing double quote (#605)

* fix: slot params missing double quote

* fix: exclude nodemodule test case

* fix: 修复onMouseover拼写错误 (#662)

* fix: esbuild install failed on node v16 (#668)

* fix: esbuild install failed on nodev16

* fix: esbuild install failed on nodev16

* fix: builtin components can't generate import statement with genSFCWithDefaultPlugin method (#656)

* fix: esbuild install failed on nodev16 (#671)

* fix: esbuild install failed on nodev16

* fix: esbuild install failed on nodev16

* fix: remove deps on root pkg.json

* fix(preview): multiple nested blocks cannot preview #663 (#665)

* fix(material): add missing componentsMap to mockServer (#701)

* fix(setting): fix bindEvent dialog visible can't work on tinyvue 3.17 (#715)

* feat(download-code): support download zip for not support browsers (#703)

* feat(download-code): support download zip for not support browsers

* feat(download-code): support download zip for not support browsers - review

* feat(download-code): support download zip for not support browsers - review

* docs: update milestone (#728)

* docs: update milestone

* fix: tab

* fix: abaolute canvas init inlineStyle should be string (#730)

* fix(download): Optimize download logic and adapt to iframe (#739)

* fix(download): Optimize download logic and adapt to iframe

* feat(cdn): change cdn from onmicrosoft to unpkg (#750)

* fix: 隐藏画布根节点的包裹元素的操作选项 (#492)

* fix(script): translate log (#549)

* fix: translate log

* Update scripts/connection.mjs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update scripts/connection.mjs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update scripts/connection.mjs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: reset spacing cannot generate correct source code (#657)

* fix: jsx slot modelvalue can't update value (#734)

* fix: jsx slot modelvalue can't update value

* fix: add unit test for updateModel event

* fix(canvas): absolute dnd update position to schema. close #664 (#751)

* fix(generate-vue):修复出码文件选择界面打包后样式丢失问题 (#789)

Co-authored-by: wangwenbing <[email protected]>

* fix(stylePanel): fix setting border-radius could not work on first time (#481)

* fix(common): fix verify required (#787)

* fix: mixed lifeCyclesContent when empty lifecycles (#810)

close #806
修复生命周期为空时,取当前页面schema生命周期值的 bug

---------

Co-authored-by: chilingling <[email protected]>
Co-authored-by: yeser <[email protected]>
Co-authored-by: wenmine <[email protected]>
Co-authored-by: Gene <[email protected]>
Co-authored-by: yaoyun8 <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: bwrong <[email protected]>
Co-authored-by: wangwenbing <[email protected]>
Co-authored-by: Xie Jay <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Sep 30, 2024
14 tasks
yy-wow pushed a commit to yy-wow/tiny-engine that referenced this pull request Oct 10, 2024
yy-wow pushed a commit to yy-wow/tiny-engine that referenced this pull request Oct 10, 2024
* fix(mockServer): mockServer page preview can't render element-plus element (opentiny#503)

* fix(style): fix render error caused by inline style breaks (opentiny#526)

* fix(metaComp): fix bug where metaHtmlText could set value to incorret schema children (opentiny#473)

* fix(vue-generator): fix globalstate codegen error (opentiny#547)

* fix(material): add componentsMap to app Schema after material build (opentiny#527)

* fix: slot params missing double quote (opentiny#605)

* fix: slot params missing double quote

* fix: exclude nodemodule test case

* fix: 修复onMouseover拼写错误 (opentiny#662)

* fix: esbuild install failed on node v16 (opentiny#668)

* fix: esbuild install failed on nodev16

* fix: esbuild install failed on nodev16

* fix: builtin components can't generate import statement with genSFCWithDefaultPlugin method (opentiny#656)

* fix: esbuild install failed on nodev16 (opentiny#671)

* fix: esbuild install failed on nodev16

* fix: esbuild install failed on nodev16

* fix: remove deps on root pkg.json

* fix(preview): multiple nested blocks cannot preview opentiny#663 (opentiny#665)

* fix(material): add missing componentsMap to mockServer (opentiny#701)

* fix(setting): fix bindEvent dialog visible can't work on tinyvue 3.17 (opentiny#715)

* feat(download-code): support download zip for not support browsers (opentiny#703)

* feat(download-code): support download zip for not support browsers

* feat(download-code): support download zip for not support browsers - review

* feat(download-code): support download zip for not support browsers - review

* docs: update milestone (opentiny#728)

* docs: update milestone

* fix: tab

* fix: abaolute canvas init inlineStyle should be string (opentiny#730)

* fix(download): Optimize download logic and adapt to iframe (opentiny#739)

* fix(download): Optimize download logic and adapt to iframe

* feat(cdn): change cdn from onmicrosoft to unpkg (opentiny#750)

* fix: 隐藏画布根节点的包裹元素的操作选项 (opentiny#492)

* fix(script): translate log (opentiny#549)

* fix: translate log

* Update scripts/connection.mjs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update scripts/connection.mjs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update scripts/connection.mjs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: reset spacing cannot generate correct source code (opentiny#657)

* fix: jsx slot modelvalue can't update value (opentiny#734)

* fix: jsx slot modelvalue can't update value

* fix: add unit test for updateModel event

* fix(canvas): absolute dnd update position to schema. close opentiny#664 (opentiny#751)

* fix(generate-vue):修复出码文件选择界面打包后样式丢失问题 (opentiny#789)

Co-authored-by: wangwenbing <[email protected]>

* fix(stylePanel): fix setting border-radius could not work on first time (opentiny#481)

* fix(common): fix verify required (opentiny#787)

* fix: mixed lifeCyclesContent when empty lifecycles (opentiny#810)

close opentiny#806
修复生命周期为空时,取当前页面schema生命周期值的 bug

---------

Co-authored-by: chilingling <[email protected]>
Co-authored-by: yeser <[email protected]>
Co-authored-by: wenmine <[email protected]>
Co-authored-by: Gene <[email protected]>
Co-authored-by: yaoyun8 <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: bwrong <[email protected]>
Co-authored-by: wangwenbing <[email protected]>
Co-authored-by: Xie Jay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants