fix: slot params missing double quote

[chilingling]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Added support for generating slot declarations correctly in Vue Single File Components (SFC).
  • Introduced mapping configuration for components from @opentiny/vue.

• Tests

  • Added test cases for generating slot declarations in Vue SFCs.

• Chores

  • Updated Vite configuration to exclude node_modules from tests.

[coderabbitai]

Walkthrough

This update focuses on enhancing Vue component generation and testing capabilities within the vue-generator package. Key changes include the adjustment of attribute handling in the handleSlotBindAttrHook function, new test cases for slot declarations in Vue Single File Components (SFCs), and a configuration update for test exclusions. Additionally, new JSON schemas and component mappings were introduced for better integration and testing of nested components.

Changes

File Path	Change Summary
packages/vue-generator/src/generator/vue/sfc/generateAttribute.js	Updated paramsValue assignment to include double quotes for array values in handleSlotBindAttrHook.
.../vue-generator/test/testcases/sfc/case06/case06.test.js	Added a new test case for validating slot declarations in Vue SFCs.
.../vue-generator/test/testcases/sfc/case06/components-map.json	Introduced a mapping configuration for the TinyTree component from @opentiny/vue.
.../vue-generator/test/testcases/sfc/case06/expected/slotTest.vue	Created a new Vue SFC to test nested component structures and script setup with dependencies and state.
.../vue-generator/test/testcases/sfc/case06/page.schema.json	Defined a JSON schema for a Vue component named "Page" with nested components.
packages/vue-generator/vite.config.mjs	Modified test configuration to exclude 'node_modules' in addition to existing patterns.

Poem

In the land of Vue a change took place,
Where slots and trees found their space,
Quotes around, in bindings bound,
With tests and mappings, new paths we found.
A config tweak for tests to run,
Ensuring all the code is fun! 🌲✨

---

Tip

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (2)

packages/vue-generator/src/generator/vue/sfc/generateAttribute.js (2)

Line range hint 167-168: Ensure default parameters are last.

Default parameters should follow the last required parameter or be a required parameter.

-  const { res: tempRes, shouldBindToState: tempShouldBindToState } = transformObjType(value, globalHooks, config) || {}
+  const { res: tempRes, shouldBindToState: tempShouldBindToState } = transformObjType(value, globalHooks, config)

Tools

Biome

[error] 232-233: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

Line range hint 245-248: Avoid using the delete operator.

Using the delete operator can impact performance. Consider setting the property to undefined instead.

-    delete props[key]
+    props[key] = undefined

Tools

Biome

[error] 232-233: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2c478ce and bdde339.

Files selected for processing (5)

• packages/vue-generator/src/generator/vue/sfc/generateAttribute.js (1 hunks)
• packages/vue-generator/test/testcases/sfc/case06/case06.test.js (1 hunks)
• packages/vue-generator/test/testcases/sfc/case06/components-map.json (1 hunks)
• packages/vue-generator/test/testcases/sfc/case06/expected/slotTest.vue (1 hunks)
• packages/vue-generator/test/testcases/sfc/case06/page.schema.json (1 hunks)

Files skipped from review due to trivial changes (2)

• packages/vue-generator/test/testcases/sfc/case06/components-map.json
• packages/vue-generator/test/testcases/sfc/case06/page.schema.json

Additional context used

Biome

packages/vue-generator/src/generator/vue/sfc/generateAttribute.js

[error] 167-168: This default parameter should follow the last required parameter or should be a required parameter.

The last required parameter is here:

A default parameter that precedes a required parameter cannot be omitted at call site.
Unsafe fix: Turn the parameter into a required parameter.

(lint/style/useDefaultParameterLast)

---

[error] 232-233: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

---

[error] 245-248: Avoid the delete operator which can impact performance.

Unsafe fix: Use an undefined assignment instead.

(lint/performance/noDelete)

Additional comments not posted (4)

packages/vue-generator/test/testcases/sfc/case06/case06.test.js (2)

1-5: Imports look good.

The necessary modules are imported, including vitest for testing, and utility functions from the project.

---

7-12: Test case looks good.

The test case verifies the correct generation of slot declarations and uses snapshot testing for validation.

packages/vue-generator/test/testcases/sfc/case06/expected/slotTest.vue (2)

1-36: Template section looks good.

The template section correctly defines the structure and data for the tiny-tree components. The slot declaration is correctly formatted with double quotes.

---

38-54: Script section looks good.

The script setup imports necessary modules and defines props, emits, and state correctly.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bdde339 and de7fc53.

Files selected for processing (1)

• packages/vue-generator/vite.config.mjs (1 hunks)

Additional comments not posted (1)

packages/vue-generator/vite.config.mjs (1)

20-20: LGTM! Verify the impact on test configurations.

Excluding node_modules from the test configuration is a common practice to improve test performance by avoiding unnecessary scans of dependencies. This change is beneficial and does not introduce any issues.

However, ensure that this change does not inadvertently exclude any important test files.

Verification successful

---

LGTM! Verify the impact on test configurations.

Excluding node_modules from the test configuration is a common practice to improve test performance by avoiding unnecessary scans of dependencies. This change is beneficial and does not introduce any issues.

• Confirmed that no important test files are located in node_modules.
• Verified the presence of test files in the repository.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the impact of excluding `node_modules` from the test configuration.

# Test: Ensure that no important test files are excluded. Expect: Only irrelevant files are excluded.
rg --type js --files --glob '!node_modules/**' --glob 'test/**'

Length of output: 65

---

---

Script:

#!/bin/bash
# Description: List all JavaScript test files in the repository to verify their presence.

# Find all JavaScript files in the `test` directory.
rg --type js --files --glob 'test/**'

Length of output: 39

---

---

Script:

#!/bin/bash
# Description: Search for JavaScript test files across the entire repository.

# Find all JavaScript test files in the repository, including common test file patterns.
rg --type js --files --glob '**/*.test.js' --glob '**/*.spec.js'

Length of output: 757