fix(stylePanel): fix setting border-radius could not work on first time

[chilingling]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

使用滑动条或者输入框设置 border-rarius，会发现第一次无法设置成功

2. 修改全局样式，会发现样式面板中的 border-radius 无法响应式更新。原因是响应式获取父级 style border-radius 字段不正确。

Issue Number: N/A

What is the new behavior?

1. 更新检测来自 props 的更新的逻辑。
2. 更新成正确的 border-radius 字段。

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Refactor

  • Improved the logic for updating border radius properties, making the code more efficient and easier to maintain.

• Bug Fixes

  • Resolved issues related to border radius updates not reflecting changes correctly.

[chilingling]

@coderabbitai review

[coderabbitai]

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

The changes in the BorderGroup.vue component focus on streamlining the logic for updating border radius properties by removing the isUpdateFromProps flag. Additionally, the component now utilizes keys from the props.style object for setting border radius properties, enhancing clarity and maintainability.

Changes

Files/Paths	Change Summary
.../styles/src/components/border/BorderGroup.vue	Removed the isUpdateFromProps flag and updated the logic for setting borderRadius properties using props.style keys. Adjusted the declaration of activedBorder to use BORDER_SETTING.All.

🐰✨
A code refactor, clean and bright,
Simplified the border's might.
Props now guide the radius round,
No flags to clutter, logic sound.
In the land of Vue, all's right.
🌟🍃

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 899d616 and 3bea516.

Files selected for processing (1)

• packages/settings/styles/src/components/border/BorderGroup.vue (3 hunks)

Additional comments not posted (3)

packages/settings/styles/src/components/border/BorderGroup.vue (3)

293-293: Initialization of activedBorder state looks good.

---

337-343: Updating borderRadius properties using keys from props.style ensures correct initial state reflection.

---

388-394: The condition to prevent unnecessary updates when the value is 0 and props.style[BORDER_RADIUS_PROPERTY.BorderRadius] does not exist is a good safeguard.