Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cmake==3.18.4 for multicoretsne build #328

Conversation

scottgigante-immunai
Copy link
Collaborator

Submission type

Testing

Submission guidelines

  • This submission follows the guidelines in our Contributing document
  • I have checked to ensure there aren't other open Pull Requests for the same update/change

PR review checklist

This PR will be evaluated on the basis of the following checks:

  • The latest version of master is merged and tested

@scottgigante-immunai
Copy link
Collaborator Author

This PR fixes #327 which means openproblems-python-extras is building successfully, but another error stops Build Docker Images from running successfully. I will fix this in another PR.

@LuckyMD
Copy link
Collaborator

LuckyMD commented Mar 16, 2022

Looks like there are still issues in the Docker builds though.

@scottgigante-immunai
Copy link
Collaborator Author

Looks like there are still issues in the Docker builds though.

Yep. The error is unrelated to this fix -- this fixes the python-extras build, but r-extras is still broken. I'm working on it elsewhere.

@scottgigante-immunai scottgigante-immunai merged commit 140b2f4 into openproblems-bio:main Mar 16, 2022
@scottgigante-immunai scottgigante-immunai deleted the scottgigante/bugfix/multicore_tsne_cmake branch March 16, 2022 14:14
lazappi added a commit to lazappi/openproblems that referenced this pull request Mar 24, 2022
* upstream/main:
  Convert normalizers to return anndata (openproblems-bio#329)
  require anndata<0.8 (openproblems-bio#336)
  Fix GPG key for R install (openproblems-bio#334)
  Fix R dependencies for docker build (openproblems-bio#331)
  Jamboree dimensionality reduction datasets (openproblems-bio#316)
  Jamboree dimensionality reduction metrics (openproblems-bio#317)
  use cmake==3.18.4 for multicoretsne build (openproblems-bio#328)
  Update 'master' to 'main' on CI (openproblems-bio#326)
  New key breaks r docker container build (openproblems-bio#322)
rcannood pushed a commit that referenced this pull request Sep 4, 2024
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v40...v41)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
rcannood pushed a commit that referenced this pull request Sep 4, 2024
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v40...v41)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Former-commit-id: 112bcbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build fails due to MulticoreTSNE error
2 participants